From issues-return-9244-archive-asf-public=cust-asf.ponee.io@aurora.apache.org Thu Jan 18 15:58:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 96E7F180654 for ; Thu, 18 Jan 2018 15:58:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 82032160C36; Thu, 18 Jan 2018 14:58:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C7C90160C2B for ; Thu, 18 Jan 2018 15:58:05 +0100 (CET) Received: (qmail 62173 invoked by uid 500); 18 Jan 2018 14:58:04 -0000 Mailing-List: contact issues-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.apache.org Delivered-To: mailing list issues@aurora.apache.org Received: (qmail 62164 invoked by uid 99); 18 Jan 2018 14:58:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 14:58:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4A7FD1A72FE for ; Thu, 18 Jan 2018 14:58:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.91 X-Spam-Level: X-Spam-Status: No, score=-99.91 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Q_EWUPqTNlls for ; Thu, 18 Jan 2018 14:58:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AB87B5F3F0 for ; Thu, 18 Jan 2018 14:58:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A7759E0F7F for ; Thu, 18 Jan 2018 14:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B260C2130D for ; Thu, 18 Jan 2018 14:58:00 +0000 (UTC) Date: Thu, 18 Jan 2018 14:58:00 +0000 (UTC) From: "Juan Manuel Fresia (JIRA)" To: issues@aurora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (AURORA-1963) Structdump endpoint shows thrift metadata MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Auto-Submitted: auto-generated [ https://issues.apache.org/jira/browse/AURORA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Manuel Fresia resolved AURORA-1963. ---------------------------------------- Resolution: Fixed Fix Version/s: 0.20.0 Patched with commit from review [65076|https://reviews.apache.org/r/65076/] > Structdump endpoint shows thrift metadata > ----------------------------------------- > > Key: AURORA-1963 > URL: https://issues.apache.org/jira/browse/AURORA-1963 > Project: Aurora > Issue Type: Bug > Components: Scheduler > Affects Versions: 0.19.0 > Environment: Devcluster VM > Reporter: Juan Manuel Fresia > Priority: Minor > Labels: patch > Fix For: 0.20.0 > > > The structdump endpoint changed the way it displays the task config. This change made some thrift internal metadata visible, such as {{__isset_bitfield}} on optionals fields and appending underscores on the names of other fields. > For example, here is a fragment of a 0.19 structdump output: > {code} > "timestamp": 1514573549125, > "status": "RUNNING", > "scheduler": "ee5feaf3d8b1", > "__isset_bitfield": 1, > "optionals": [ > "MESSAGE", > "SCHEDULER" > ] > {code} > And here is the same fragment, but with 0.18 scheduler: > {code} > Item[2] = > timestamp: 1514574966299 > status: RUNNING > message: not set > scheduler: "84611e03fe9e" > {code} > As the structdump is the only way to get the full configuration of a task through the UI, it is inconvenient to have those fields and naming messing around. > The issue seems to be caused by a change in the way data taken from thrift is converted to be pretty printed; by changing a thrift specific converter to a GSON serializer. The proposed fix is to backport the old converter and restore the old structdump style. > The review of the change related to the issue is [here|https://reviews.apache.org/r/63418/diff/3#16] > The old pretty print utility used in 0.18 is [here|https://github.com/apache/aurora/blob/87eb8914b3d79a0d27a91c50cc7070970e47abf9/commons/src/main/java/org/apache/aurora/common/thrift/Util.java] -- This message was sent by Atlassian JIRA (v7.6.3#76005)