aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-1951) UI build broken in gradle 4.2
Date Wed, 27 Sep 2017 17:47:01 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182977#comment-16182977
] 

David McLaughlin commented on AURORA-1951:
------------------------------------------

The file is written correctly the first time. I don't know why subsequent runs are overwriting
the file:

{noformat}
$ ls -al /Users/dmclaughlin/t/apache-aurora/ui/.gradle/nodejs/node-v6.9.1-darwin-x64/lib/node_modules/npm/bin
total 32
...
-rwxr-xr-x   1 dmclaughlin  staff  1996 Sep 27 10:44 npm-cli.js
...
apache-aurora$ ./gradlew --rerun-tasks ui:lint

BUILD SUCCESSFUL in 7s
3 actionable tasks: 3 executed
apache-aurora$ ls -al /Users/dmclaughlin/t/apache-aurora/ui/.gradle/nodejs/node-v6.9.1-darwin-x64/lib/node_modules/npm/bin
...
-rwxr-xr-x   1 dmclaughlin  staff    0 Sep 27 10:45 npm-cli.js
...
{noformat}

> UI build broken in gradle 4.2
> -----------------------------
>
>                 Key: AURORA-1951
>                 URL: https://issues.apache.org/jira/browse/AURORA-1951
>             Project: Aurora
>          Issue Type: Task
>            Reporter: David McLaughlin
>            Assignee: Bill Farner
>
> The recent upgrade to gradle 4.2 has broken the previously working ui build. It was a
bit of a nightmare for me to get this working originally and unfortunately I don't have the
bandwidth to bisect the changelog to see what they've changed. 
> Here is the symptom of a false positive result:
> {noformat}
> $ ./gradlew --rerun-tasks ui:lint
> BUILD SUCCESSFUL in 8s
> 3 actionable tasks: 3 executed
> apache-aurora$ cd ui
> ui$ 
> ui$ npm run lint
> > apache-aurora@1.0.0 lint /Users/dmclaughlin/t/apache-aurora/ui
> > eslint src/main/js --ext .js
> /Users/dmclaughlin/t/apache-aurora/ui/src/main/js/components/Icon.js
>   3:7  error  'test' is assigned a value but never used  no-unused-vars
> ✖ 1 problem (1 error, 0 warnings)
> {noformat}
> I'm not totally sure which version of Gradle causes the regression.
> I also saw issues with changing files and Gradle still considering the task UP-TO-DATE.
This would cause false positives in other ways and general make it unpleasant to work in the
UI. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message