Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 498A6200CA3 for ; Wed, 17 May 2017 15:21:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 48474160BB5; Wed, 17 May 2017 13:21:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 95CF7160BBA for ; Wed, 17 May 2017 15:21:09 +0200 (CEST) Received: (qmail 40069 invoked by uid 500); 17 May 2017 13:21:08 -0000 Mailing-List: contact issues-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.apache.org Delivered-To: mailing list issues@aurora.apache.org Received: (qmail 40050 invoked by uid 99); 17 May 2017 13:21:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 May 2017 13:21:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1FEE5CCCB0 for ; Wed, 17 May 2017 13:21:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PrDwz6nA8lUx for ; Wed, 17 May 2017 13:21:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F2CD66106C for ; Wed, 17 May 2017 13:21:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 508CAE0DCC for ; Wed, 17 May 2017 13:21:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8AF5A263B6 for ; Wed, 17 May 2017 13:21:04 +0000 (UTC) Date: Wed, 17 May 2017 13:21:04 +0000 (UTC) From: "Stephan Erb (JIRA)" To: issues@aurora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AURORA-1237) thermos_runner never does setuid inside the docker container MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 17 May 2017 13:21:10 -0000 [ https://issues.apache.org/jira/browse/AURORA-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014017#comment-16014017 ] Stephan Erb commented on AURORA-1237: ------------------------------------- Yeah, the specific patch is kind of abandoned. The feature is useful though, we are therefore happy to accept rebased/improved patches. > thermos_runner never does setuid inside the docker container > ------------------------------------------------------------ > > Key: AURORA-1237 > URL: https://issues.apache.org/jira/browse/AURORA-1237 > Project: Aurora > Issue Type: Bug > Components: Docker > Reporter: Jay Buffington > Assignee: Benjamin Staffin > > Even if you do not specify --nosetuid to the aurora executor, the executor does not pass the --setuid argument to the thermos runner when using the docker containerizer. > Commit 7ba6226 changed this line: > https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/thermos_task_runner.py#L378 > I believe that change was inadvertent and was the result of back and forth during the code review process when --nosetuid was being introduced. That line should be reverted back to how it was before 7ba6226. -- This message was sent by Atlassian JIRA (v6.3.15#6346)