Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3E4B200C34 for ; Mon, 27 Feb 2017 20:06:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F2812160B6C; Mon, 27 Feb 2017 19:06:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 44730160B5B for ; Mon, 27 Feb 2017 20:06:49 +0100 (CET) Received: (qmail 35379 invoked by uid 500); 27 Feb 2017 19:06:48 -0000 Mailing-List: contact issues-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.apache.org Delivered-To: mailing list issues@aurora.apache.org Received: (qmail 35370 invoked by uid 99); 27 Feb 2017 19:06:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Feb 2017 19:06:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EFF06C13AC for ; Mon, 27 Feb 2017 19:06:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id izRS2G_Acw6N for ; Mon, 27 Feb 2017 19:06:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2BAF35FE16 for ; Mon, 27 Feb 2017 19:06:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D0EAE073F for ; Mon, 27 Feb 2017 19:06:46 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 681182413A for ; Mon, 27 Feb 2017 19:06:45 +0000 (UTC) Date: Mon, 27 Feb 2017 19:06:45 +0000 (UTC) From: "Zameer Manji (JIRA)" To: issues@aurora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (AURORA-1860) Fix bug in scheduler driver disconnect stats MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 27 Feb 2017 19:06:50 -0000 [ https://issues.apache.org/jira/browse/AURORA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zameer Manji resolved AURORA-1860. ---------------------------------- Resolution: Fixed {noformat} commit 2652fe02a2255992e187fede2bae8ff6aef2862c Author: Ilya Pronin Date: Mon Feb 27 11:04:54 2017 -0800 Fix scheduler_framework_disconnects stat. Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back. Testing Done: Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint. Bugs closed: AURORA-1860 Reviewed at https://reviews.apache.org/r/57074/ .../java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java | 2 +- .../java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) {noformat} > Fix bug in scheduler driver disconnect stats > -------------------------------------------- > > Key: AURORA-1860 > URL: https://issues.apache.org/jira/browse/AURORA-1860 > Project: Aurora > Issue Type: Task > Components: Scheduler > Reporter: Mehrdad Nurolahzade > Assignee: Ilya Pronin > Priority: Minor > Labels: newbie > > Correct the refactoring mistake introduced in [https://reviews.apache.org/r/31550/] that has disabled {{scheduler_framework_disconnects}} stats: > {code:title=MesosSchedulerImpl.disconnected()} > counters.get("scheduler_framework_disconnects").get(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)