aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-1894) Inline preemption filter in PreemptionVictimFilterImpl
Date Fri, 17 Feb 2017 09:05:41 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871481#comment-15871481
] 

Stephan Erb commented on AURORA-1894:
-------------------------------------

I am surprised that the JVM did not optimize this properly. 

How where you profiling here? Simple sampling or true profiling that had to alter the byte
code to inject instrumentation?

> Inline preemption filter in PreemptionVictimFilterImpl
> ------------------------------------------------------
>
>                 Key: AURORA-1894
>                 URL: https://issues.apache.org/jira/browse/AURORA-1894
>             Project: Aurora
>          Issue Type: Task
>          Components: Scheduler
>            Reporter: Mehrdad Nurolahzade
>            Priority: Minor
>              Labels: newbie
>
> Profiling preemption logic, I can see {{PreemptionVictimFilterImpl#preemptionFilter()}}
is producing ~200K/sec lambda objects to be used by {{filterPreemptionVictims()}}:
> {code:title=PreemptionVictimFilterImpl.filterPreemptionVictims()}
>       FluentIterable<PreemptionVictim> preemptableTasks = FluentIterable.from(possibleVictims)
>           .filter(preemptionFilter(pendingTask));
> {code}
> Inline this logic (refactor to loop) to remove the need to create these short-lived lambda
objects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message