aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AURORA-1846) Add message parameter to killTasks RPC
Date Mon, 06 Feb 2017 18:44:41 GMT

     [ https://issues.apache.org/jira/browse/AURORA-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zameer Manji resolved AURORA-1846.
----------------------------------
    Resolution: Fixed

This is fixed on master:
{noformat}
commit f88b7f3bf5b7a7db6e422e38cbf22cf809f8ff87
Author: Cody Gibb <codyhgibb@gmail.com>
Date:   Mon Feb 6 10:43:01 2017 -0800

    Add message parameter to killTasks
    
    RPC's such as pauseJobUpdate include a parameter for "a user-specified message
    to include with the induced job update state change." This diff provides a
    similar optional parameter for the killTasks RPC, which allows users to indicate
    the reason why a task was killed, and later inspect that reason when consuming
    task events.
    
    Example usage from Aurora CLI:
    `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
    
    In the task event, the supplied message (if provided) is appended to the
    existing template "Killed by <user>", separated by a newline. For the above
    example, this looks like: "Killed by aurora\nSome message".
    
    Testing Done:
    Added a unit test in the scheduler, and a test in the client.
    
    Also manually tested using the Vagrant environment.
    
    Bugs closed: AURORA-1846
    
    Reviewed at https://reviews.apache.org/r/54459/

 RELEASE-NOTES.md                                   |  7 +++
 .../main/thrift/org/apache/aurora/gen/api.thrift   |  2 +-
 .../aurora/scheduler/thrift/AuditMessages.java     |  6 ++-
 .../scheduler/thrift/SchedulerThriftInterface.java |  8 +++-
 .../scheduler/thrift/aop/AnnotatedAuroraAdmin.java |  3 +-
 .../python/apache/aurora/client/api/__init__.py    |  4 +-
 src/main/python/apache/aurora/client/cli/jobs.py   | 10 +++--
 .../apache/aurora/client/hooks/hooked_api.py       |  9 ++--
 .../http/api/security/HttpSecurityIT.java          | 21 ++++-----
 .../ShiroAuthorizingParamInterceptorTest.java      |  4 +-
 .../aurora/scheduler/thrift/AuditMessagesTest.java | 26 ++++++++++-
 .../thrift/SchedulerThriftInterfaceTest.java       | 27 +++++++++---
 src/test/python/apache/aurora/api_util.py          |  2 +-
 .../aurora/client/api/test_scheduler_client.py     | 10 ++---
 .../python/apache/aurora/client/cli/test_kill.py   | 50 ++++++++++++++++------
 .../apache/aurora/client/hooks/test_hooked_api.py  |  2 +-
 .../aurora/client/hooks/test_non_hooked_api.py     |  6 +--
 .../sh/org/apache/aurora/e2e/test_end_to_end.sh    | 10 ++++-
 18 files changed, 146 insertions(+), 61 deletions(-)
{noformat}



> Add message parameter to killTasks RPC
> --------------------------------------
>
>                 Key: AURORA-1846
>                 URL: https://issues.apache.org/jira/browse/AURORA-1846
>             Project: Aurora
>          Issue Type: Task
>          Components: Client, Scheduler
>    Affects Versions: 0.16.0
>            Reporter: Cody Gibb
>            Assignee: Cody Gibb
>            Priority: Minor
>
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include
with the induced job update state change." Having a similar parameter for killTasks would
allow us to indicate the reason why a task was killed, and later inspect that reason when
querying getTasksWithoutConfigs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message