aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-1599) HealthCheckerConfig should validate it has only 1 set field
Date Fri, 16 Sep 2016 11:52:20 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496106#comment-15496106
] 

Stephan Erb commented on AURORA-1599:
-------------------------------------

For reference: This is now possible since https://github.com/wickman/pystachio/commit/43a6c9db78a32beee51034a8a59cb0374e01c8c4


> HealthCheckerConfig should validate it has only 1 set field
> -----------------------------------------------------------
>
>                 Key: AURORA-1599
>                 URL: https://issues.apache.org/jira/browse/AURORA-1599
>             Project: Aurora
>          Issue Type: Story
>          Components: Client
>            Reporter: John Sirois
>            Priority: Minor
>
> As discussed in https://reviews.apache.org/r/42816/ - the {{HealthCheckerConfig}} struct
has 2 fields, but these 2 fields are treated like a union today behind the scenes.  This union-style
treatment is silent - we check for a {{shell}} 1st and use it and ignore {{http}} if also
populated.  This could lead to user confusion.  It would be better to fail fast if both types
of health check are configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message