aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-1721) Support user initiated rollback
Date Thu, 11 Aug 2016 21:00:23 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417927#comment-15417927
] 

Zameer Manji commented on AURORA-1721:
--------------------------------------

I landed [/r/50168/|https://reviews.apache.org/r/50168/]:
{noformat}
commit a4fdf284d878c9430f267e2051a1ae97355d0ddb
Author: Igor Morozov <igmorv@gmail.com>
Date:   Thu Aug 11 13:56:48 2016 -0700

    Add rollback functionality to the scheduler
    
    For active job updates in ROLLING_FORWARD, ROLL_BACK_PAUSED,
    ROLL_BACK_AWAITING_PULSE, ROLL_FORWARD_PAUSED or ROLL_FORWARD_AWAITING_PULSE
    state it is possible now to initiate a rollback by calling a corresponding API
    function.  Rollback is also supported in aurora CLI tool via new command: aurora
    update rollback CLUSTER/ROLE/ENV/NAME
    
    Bugs closed: AURORA-1721
    
    Reviewed at https://reviews.apache.org/r/50168/

 CHANGELOG                                          |   3 +-
 RELEASE-NOTES.md                                   |   2 +
 .../main/thrift/org/apache/aurora/gen/api.thrift   |   9 +
 .../scheduler/thrift/SchedulerThriftInterface.java |   8 +
 .../scheduler/thrift/aop/AnnotatedAuroraAdmin.java |   5 +
 .../scheduler/updater/JobUpdateController.java     |  20 ++
 .../scheduler/updater/JobUpdateControllerImpl.java |   7 +
 .../scheduler/updater/JobUpdateStateMachine.java   |  14 +-
 .../python/apache/aurora/client/api/__init__.py    |  11 ++
 src/main/python/apache/aurora/client/cli/update.py |  97 ++++++---
 .../updater/JobUpdateStateMachineTest.java         |   2 +
 .../aurora/scheduler/updater/JobUpdaterIT.java     | 220 ++++++++++++++++++++-
 .../aurora/client/api/test_scheduler_client.py     |   5 +
 .../apache/aurora/client/cli/test_supdate.py       |  86 ++++++++
 14 files changed, 459 insertions(+), 30 deletions(-)
{noformat}

This adds support for rolling back in progress updates. Thanks [~igmorv]!

> Support user initiated rollback 
> --------------------------------
>
>                 Key: AURORA-1721
>                 URL: https://issues.apache.org/jira/browse/AURORA-1721
>             Project: Aurora
>          Issue Type: Task
>          Components: Scheduler
>            Reporter: Igor Morozov
>            Assignee: Igor Morozov
>              Labels: Uber
>             Fix For: 0.16.0
>
>
> The proposal to support user initiated rollback:
> 1. Create new thrift API:
>  /**Rollback job update. */
>   Response rollbackJobUpdate(
>       /** The update to rollback. */
>       1: JobUpdateKey key,
>       /** A user-specified message to include with the induced job update state change.
*/
>       3: string message)
> 2.  Implement new API in a scheduler so the implementation would just undo the latest
JobUpdate effectively trying to apply initialState to the job. If that is for some reason
is impossible them rollback with fail with appropriate error message.
> 3. Support new aurora client command 'rollback'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message