aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Staffin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-1237) thermos_runner never does setuid inside the docker container
Date Tue, 23 Aug 2016 21:09:22 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433610#comment-15433610
] 

Benjamin Staffin commented on AURORA-1237:
------------------------------------------

https://reviews.apache.org/r/43027/

> thermos_runner never does setuid inside the docker container
> ------------------------------------------------------------
>
>                 Key: AURORA-1237
>                 URL: https://issues.apache.org/jira/browse/AURORA-1237
>             Project: Aurora
>          Issue Type: Bug
>          Components: Docker
>            Reporter: Jay Buffington
>            Assignee: Benjamin Staffin
>
> Even if you do not specify --nosetuid to the aurora executor, the executor does not pass
the --setuid argument to the thermos runner when using the docker containerizer.
> Commit 7ba6226 changed this line:
> https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/thermos_task_runner.py#L378
> I believe that change was inadvertent and was the result of back and forth during the
code review process when --nosetuid was being introduced.  That line should be reverted back
to how it was before 7ba6226.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message