aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AURORA-1625) ConcurrentModificationException in TaskHistoryPruner with DbTaskStore
Date Sat, 27 Feb 2016 00:00:20 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170148#comment-15170148
] 

Zameer Manji edited comment on AURORA-1625 at 2/26/16 11:59 PM:
----------------------------------------------------------------

{noformat}
commit 8f98e6e8a50e59abfd4b80a0aa2696a6bed6daf9
Author: Zameer Manji <zmanji@apache.org>
Date:   Fri Feb 26 15:58:01 2016 -0800

    Do not modify list populated by MyBatis.
    
    A ConcurrentModificationException can occur when multiple threads are sorting
    the same task event list. This is possible because we have enabled MyBatis
    caching with the readOnly flag which can use the same instance to populate
    different `DbScheduledTask` instances.
    
    Bugs closed: AURORA-1625
    
    Reviewed at https://reviews.apache.org/r/44106/

 .../storage/db/views/DbScheduledTask.java          |  6 ++---
 .../scheduler/storage/AbstractTaskStoreTest.java   | 29 ++++++++++++++++++++++
 2 files changed, 32 insertions(+), 3 deletions(-)
{noformat}


was (Author: zmanji):
````
commit 8f98e6e8a50e59abfd4b80a0aa2696a6bed6daf9
Author: Zameer Manji <zmanji@apache.org>
Date:   Fri Feb 26 15:58:01 2016 -0800

    Do not modify list populated by MyBatis.
    
    A ConcurrentModificationException can occur when multiple threads are sorting
    the same task event list. This is possible because we have enabled MyBatis
    caching with the readOnly flag which can use the same instance to populate
    different `DbScheduledTask` instances.
    
    Bugs closed: AURORA-1625
    
    Reviewed at https://reviews.apache.org/r/44106/

 .../storage/db/views/DbScheduledTask.java          |  6 ++---
 .../scheduler/storage/AbstractTaskStoreTest.java   | 29 ++++++++++++++++++++++
 2 files changed, 32 insertions(+), 3 deletions(-)
`````

> ConcurrentModificationException in TaskHistoryPruner with DbTaskStore
> ---------------------------------------------------------------------
>
>                 Key: AURORA-1625
>                 URL: https://issues.apache.org/jira/browse/AURORA-1625
>             Project: Aurora
>          Issue Type: Bug
>            Reporter: Zameer Manji
>            Assignee: Zameer Manji
>
> {noformat}
> E0226 19:39:03.406 [AsyncProcessor-6, TaskHistoryPruner:145] Unexpected problem pruning
task history for job: IJobKey{role=mesos, environment=test, name=labrat}. Triggering shutdown
java.util.ConcurrentModificationException: null
>         at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) ~[na:1.8.0_72-Tw8r10b0]
>         at java.util.ArrayList$Itr.next(ArrayList.java:851) ~[na:1.8.0_72-Tw8r10b0]
>         at com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
~[guava-19.0.jar:na]
>         at com.google.common.collect.ImmutableCollection$Builder.addAll(ImmutableCollection.java:410)
~[guava-19.0.jar:na]
>         at com.google.common.collect.ImmutableList$Builder.addAll(ImmutableList.java:692)
~[guava-19.0.jar:na]
>         at com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:256) ~[guava-19.0.jar:na]
>         at com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:209) ~[guava-19.0.jar:na]
>         at com.google.common.collect.FluentIterable.toList(FluentIterable.java:484) ~[guava-19.0.jar:na]
>         at org.apache.aurora.scheduler.storage.entities.IScheduledTask.<init>(IScheduledTask.java:40)
~[aurora-api-144.jar:na]
>         at org.apache.aurora.scheduler.storage.entities.IScheduledTask.build(IScheduledTask.java:46)
~[aurora-api-144.jar:na]
>         at org.apache.aurora.scheduler.storage.db.views.DbScheduledTask.toImmutable(DbScheduledTask.java:39)
~[aurora-144.jar:na]
>         at com.google.common.collect.Iterators$8.transform(Iterators.java:817) ~[guava-19.0.jar:na]
>         at com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
~[guava-19.0.jar:na]
>         at com.google.common.collect.Iterators$7.computeNext(Iterators.java:674) ~[guava-19.0.jar:na]
>         at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
~[guava-19.0.jar:na]
>         at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
~[guava-19.0.jar:na]
>         at com.google.common.collect.Iterators.size(Iterators.java:200) ~[guava-19.0.jar:na]
>         at com.google.common.collect.Iterables.size(Iterables.java:107) ~[guava-19.0.jar:na]
>         at org.apache.aurora.scheduler.pruning.TaskHistoryPruner.lambda$registerInactiveTask$85(TaskHistoryPruner.java:170)
~[aurora-144.jar:na]
>         at org.apache.aurora.scheduler.pruning.TaskHistoryPruner.lambda$shutdownOnError$83(TaskHistoryPruner.java:143)
~[aurora-14        at org.apache.aurora.scheduler.pruning.TaskHistoryPruner.lambda$shutdownOnError$83(TaskHistoryPruner.java:143)
~[aurora-14
> 4.jar:na]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_72-Tw8r10b0]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_72-Tw8r10b0]
>         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
~[na:1.8.0_72-Tw8r10b0]
>         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
~[na:1.8.0_72-Tw8r10b0]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
~[na:1.8.0_72-Tw8r10b0]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
~[na:1.8.0_72-Tw8r10b0]
>         at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_72-Tw8r10b0]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message