aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AURORA-1467) Replace org.apache.aurora.common.args with a standard third-party library
Date Thu, 05 Nov 2015 22:01:27 GMT

    [ https://issues.apache.org/jira/browse/AURORA-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992324#comment-14992324
] 

Zameer Manji edited comment on AURORA-1467 at 11/5/15 10:00 PM:
----------------------------------------------------------------

I have recently learned that the argument parsing library from Twitter Commons has some bugs
in the annotation processor code, which explains why running the gradle daemon causes compilation
issues.

Specifically, I have been told that the code in the {{org.apache.aurora.common.args.apt}}
package assumes it has a global view of the classpath which is not true with incremental compiles
such as when compiling with the gradle daemon. The assumption of seeing the entire classpath
means that on subsequent incremental compiles the args processor will write out a {{cmdline.arg.info.txt}}
file that does not cover all the classes and will clobber the previously created {{cmdline.arg.info.txt}}.
This will break the argument parsing as the {{cmdline.arg.info.txt}} will not contain all
of the information needed to parse all of the arguments declared.

I am bumping the priority of this issue as it signals we are on non standard and buggy code.


was (Author: zmanji):
I have recently learned that the argument parsing library from Twitter Commons has some bugs
in the annotation processor code, which explains why running the gradle daemon causes compilation
issues. I am bumping the priority of this issue as it signals we are on non standard and buggy
code.

> Replace org.apache.aurora.common.args with a standard third-party library
> -------------------------------------------------------------------------
>
>                 Key: AURORA-1467
>                 URL: https://issues.apache.org/jira/browse/AURORA-1467
>             Project: Aurora
>          Issue Type: Task
>          Components: Scheduler
>            Reporter: Bill Farner
>              Labels: newbie
>
> Our args parsing/processing system was inherited from Twitter Commons and should be considered
for replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message