aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko (JIRA)" <>
Subject [jira] [Commented] (AURORA-1501) Add a job update diff RPC
Date Thu, 08 Oct 2015 20:24:29 GMT


Maxim Khutornenko commented on AURORA-1501:

Design doc:

> Add a job update diff RPC 
> --------------------------
>                 Key: AURORA-1501
>                 URL:
>             Project: Aurora
>          Issue Type: Epic
>          Components: Client, Scheduler
>            Reporter: Maxim Khutornenko
> {quote}
> Problem:
> We currently don't have a good user experience around "aurora job
> diff" command. The task configs are dumped as "prettified" JSON
> strings and diffed with the system diff tool. Anyone who tried to use
> it knows it can be very hard to read especially when it comes to
> executor data deltas. Also, the implementation is done completely
> within the Aurora client making it hard to reuse this feature by other
> clients (e.g.: an external deploy coordination tool).
> Proposal:
> Move the diff logic to the scheduler and expose it via a new
> jobConfigDiff thrift API.
> Benefits:
> - Client will no longer have the custom non-reusable logic moving us
> closer towards a "thin client" goal.
> - The new RPC can be fully used by any existing or new API clients.
> - The diff output will be improved via leveraging third party POJO
> and/or JSON diff libraries (1,2,3, etc.).
> - The server updater can be partially/fully unified with the new diff
> logic further improving the overall DRY-ness.
> Concerns:
> - The executor data is currently treated as an opaque string blob on
> the scheduler side. In reality, it's almost guaranteed to be JSON. In
> order to deliver the best UX, the scheduler would have to start
> requiring to be a valid JSON.
> (1) -
> (2) -
> (3) -
> {quote}
> Full background here:
> *NOTE: the current agreement is to pursue the instance update details (e.g.: added, killed,
updated) and add TaskConfig diff details later. See dev thread for more details.*

This message was sent by Atlassian JIRA

View raw message