Return-Path: X-Original-To: apmail-aurora-issues-archive@minotaur.apache.org Delivered-To: apmail-aurora-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BA5618797 for ; Tue, 22 Sep 2015 22:38:04 +0000 (UTC) Received: (qmail 53919 invoked by uid 500); 22 Sep 2015 22:38:04 -0000 Delivered-To: apmail-aurora-issues-archive@aurora.apache.org Received: (qmail 53872 invoked by uid 500); 22 Sep 2015 22:38:04 -0000 Mailing-List: contact issues-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.apache.org Delivered-To: mailing list issues@aurora.apache.org Received: (qmail 53862 invoked by uid 99); 22 Sep 2015 22:38:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 22:38:04 +0000 Date: Tue, 22 Sep 2015 22:38:04 +0000 (UTC) From: "Kevin Sweeney (JIRA)" To: issues@aurora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (AURORA-1498) aurora task run doesn't accept aliased port names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Kevin Sweeney created AURORA-1498: ------------------------------------- Summary: aurora task run doesn't accept aliased port names Key: AURORA-1498 URL: https://issues.apache.org/jira/browse/AURORA-1498 Project: Aurora Issue Type: Bug Reporter: Kevin Sweeney Aurora task run allows you to specify a port name and have it expanded, e.g. {noformat} aurora task run us-west-1/mesos/prod/labrat/0 'curl -s http://localhost:{{thermos.ports[admin]}}/vars | grep jvm_uptime' {noformat} However, only the canonical name works here, any ports aliased with {{portmap}} do not. This is because the client uses the list of ports on the scheduler and does not take into account the portmap during template substitution. [1] This is confusing, as aliased port names work fine in the aurora config file. I see a couple ways forward: (1) Populate the portmap as metadata in the config sent to the scheduler and use that in addition to {{assignedPorts}}. (2) Parse {{the portmap}} from the task JSON in the Thrift {{executorConfig}} field and merge it with {{assignedPorts}}. (3) Improve the error message to note that {{aurora task run}} requires the canonical port name. (3) is the easiest but least user-friendly. (1) is backwards-incompatible but allows the portmap data to be used by the aurora UI too. (2) is backwards-compatible, but would require knowledge of the Thermos Task schema to be usable on the UI. My preference is for (2). [1] https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/api/command_runner.py#L67 -- This message was sent by Atlassian JIRA (v6.3.4#6332)