Return-Path: X-Original-To: apmail-aurora-issues-archive@minotaur.apache.org Delivered-To: apmail-aurora-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 887DB185D8 for ; Thu, 9 Jul 2015 17:56:05 +0000 (UTC) Received: (qmail 926 invoked by uid 500); 9 Jul 2015 17:56:05 -0000 Delivered-To: apmail-aurora-issues-archive@aurora.apache.org Received: (qmail 793 invoked by uid 500); 9 Jul 2015 17:56:05 -0000 Mailing-List: contact issues-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.apache.org Delivered-To: mailing list issues@aurora.apache.org Received: (qmail 631 invoked by uid 99); 9 Jul 2015 17:56:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 17:56:05 +0000 Date: Thu, 9 Jul 2015 17:56:05 +0000 (UTC) From: "Renan DelValle (JIRA)" To: issues@aurora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AURORA-1376) Create support for custom executors in Scheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AURORA-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620942#comment-14620942 ] Renan DelValle commented on AURORA-1376: ---------------------------------------- [~jaybuff]], you make some great points. The JSON schema comes from trying to simulate the ExecutorSettings data structure in the Aurora Scheduler. As I've said previously, the schema is subject to change, so I appreciate your suggestions. Here are the reasons why ExecutorSettings, as it exists right now, is different from ExecutorInfo: a. The ExecutorSettings data struct uses the CommandUtil (org/apache/aurora/scheduler/base/CommandUtil.java) wrapper to configure the CommandInfo to fetch and execute given URIs for an executor. [~wfarner], is this feature considered part of Aurora or part of Thermos? b. It also stores info about global container mounts. which it uses when creating docker containers. If we create an interface, IMO, it should return a TaskInfo.Builder, as that would spare us from having a special case for the mesos command executor. For what it's worth, an early version of my code is here https://reviews.apache.org/r/36289/. I've fixed all the errors that were caused by my changes and will be putting up a new version up later on today. As for having the client send in any info to configure the executor, we had a discussion a short while ago and came to the conclusion, that amongst other things, it is considered a security risk due to the fact that Aurora runs as root (https://issues.apache.org/jira/browse/AURORA-1288?focusedCommentId=14601470&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601470) Thus, IMO, using a server-side config file is still the best option. > Create support for custom executors in Scheduler > ------------------------------------------------ > > Key: AURORA-1376 > URL: https://issues.apache.org/jira/browse/AURORA-1376 > Project: Aurora > Issue Type: Sub-task > Components: Scheduler > Reporter: Renan DelValle > -- This message was sent by Atlassian JIRA (v6.3.4#6332)