Mailing-List: contact issues-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aurora.apache.org
Date: Thu, 18 Jun 2015 21:47:00 +0000 (UTC)
From: "Kevin Sweeney (JIRA)" <jira@apache.org>
To: issues@aurora.apache.org
Message-ID: <JIRA.12838951.1434663961000.114270.1434664020376@Atlassian.JIRA>
In-Reply-To: <JIRA.12838951.1434663961000@Atlassian.JIRA>
References: <JIRA.12838951.1434663961000@Atlassian.JIRA>
 <JIRA.12838951.1434663961056@arcas>
Subject: [jira] [Created] (AURORA-1357) Consider enabling
 requireExplicitBindings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Kevin Sweeney created AURORA-1357:
-------------------------------------

             Summary: Consider enabling requireExplicitBindings
                 Key: AURORA-1357
                 URL: https://issues.apache.org/jira/browse/AURORA-1357
             Project: Aurora
          Issue Type: Bug
          Components: Scheduler
            Reporter: Kevin Sweeney


Right now our Guice configuration allows the creation of JIT bindings, which makes it hard to reason about which injector a provider will be created in. We should consider turning up the [requireExplicitBindings|http://google.github.io/guice/api-docs/3.0/javadoc/com/google/inject/Binder.html#requireExplicitBindings()] flag to avoid the pitfalls seen in https://reviews.apache.org/r/35627/.

Since we've released 0.8.0 with a security SPI defined in terms of Guice Modules this would be a backwards-incompatible change. We should introduce this change with a deprecation warning message when implicit bindings are detected.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)