aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-997) ReviewBot is a filthy liar
Date Fri, 09 Jan 2015 20:18:34 GMT

    [ https://issues.apache.org/jira/browse/AURORA-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271814#comment-14271814
] 

Bill Farner commented on AURORA-997:
------------------------------------

I'm going for set -o pipefail instead.  See second response here: http://stackoverflow.com/questions/6871859/piping-command-output-to-tee-but-also-save-exit-code-of-command

> ReviewBot is a filthy liar
> --------------------------
>
>                 Key: AURORA-997
>                 URL: https://issues.apache.org/jira/browse/AURORA-997
>             Project: Aurora
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Bill Farner
>            Priority: Blocker
>
> ReviewBot was changed in https://reviews.apache.org/r/28452/ to tee output, and in doing
so, builds are always marked green.
> The culprit is this command, which does not return non-zero if build.sh returns non-zero:
> {noformat}
> bash -c ./build-support/jenkins/build.sh 2>&1 | tee foo
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message