Return-Path: X-Original-To: apmail-aurora-issues-archive@minotaur.apache.org Delivered-To: apmail-aurora-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19EE11754B for ; Mon, 6 Oct 2014 16:59:03 +0000 (UTC) Received: (qmail 70555 invoked by uid 500); 6 Oct 2014 16:59:03 -0000 Delivered-To: apmail-aurora-issues-archive@aurora.apache.org Received: (qmail 70524 invoked by uid 500); 6 Oct 2014 16:59:02 -0000 Mailing-List: contact issues-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list issues@aurora.incubator.apache.org Received: (qmail 70513 invoked by uid 99); 6 Oct 2014 16:59:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 16:59:02 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 06 Oct 2014 16:58:40 +0000 Received: (qmail 68670 invoked by uid 99); 6 Oct 2014 16:58:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 16:58:38 +0000 Date: Mon, 6 Oct 2014 16:58:38 +0000 (UTC) From: "Chris Lambert (JIRA)" To: issues@aurora.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AURORA-780) python checkstyle looks at 3rdparty MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AURORA-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated AURORA-780: --------------------------------- Sprint: Aurora Q3 Sprint 3, Aurora Q4 Sprint 1 (was: Aurora Q3 Sprint 3) > python checkstyle looks at 3rdparty > ----------------------------------- > > Key: AURORA-780 > URL: https://issues.apache.org/jira/browse/AURORA-780 > Project: Aurora > Issue Type: Bug > Components: Build > Reporter: Kevin Sweeney > Assignee: Joshua Cohen > > When attempting to commit https://reviews.apache.org/r/25835/ I was blocked by Python checkstyle, as the rename of checked-in bootstrap test files (some written in python) was picked up. > {noformat} > T401:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:002 From import must import names in lexical order. > |from __future__ import absolute_import, unicode_literals, print_function, division > T401:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:005 From import must import names in lexical order. > |from os import environ, stat, remove as _delete_file > T401:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:006 From import must import names in lexical order. > |from os.path import isfile, dirname, basename, abspath > T405:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:004 Import block starting here contains imports from multiple module types: stdlib 3rdparty. > |from sys import argv > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:018 Indentation of 4 instead of 2 > | BUCKET_NAME = environ['TWBS_S3_BUCKET'] > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:020 Indentation of 4 instead of 2 > | raise SystemExit("TWBS_S3_BUCKET environment variable not set!") > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:024 Indentation of 4 instead of 2 > | hasher = sha256() > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:026 Indentation of 4 instead of 2 > | hasher.update(input_file.read()) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:033 Indentation of 4 instead of 2 > | try: > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:034 Indentation of 4 instead of 2 > | _delete_file(filename) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:036 Indentation of 4 instead of 2 > | pass > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:040 Indentation of 4 instead of 2 > | kib = stat(_tarball_filename_for(directory)).st_size // BYTES_PER_MB > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:045 Indentation of 4 instead of 2 > | return abspath('./{}.tar.gz'.format(basename(directory))) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:049 Indentation of 4 instead of 2 > | print("Creating tarball of {}...".format(directory)) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:054 Indentation of 4 instead of 2 > | print("Extracting tarball of {}...".format(directory)) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:059 Indentation of 4 instead of 2 > | _delete_file_quietly(NEED_TO_UPLOAD_MARKER) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:061 Indentation of 4 instead of 2 > | print("Downloading {} tarball from S3...".format(friendly_name)) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:064 Indentation of 4 instead of 2 > | open(NEED_TO_UPLOAD_MARKER, 'a').close() > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:073 Indentation of 4 instead of 2 > | _create_tarball(directory) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:084 Indentation of 4 instead of 2 > | argv.pop(0) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:086 Indentation of 4 instead of 2 > | raise SystemExit("USAGE: s3_cache.py ") > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:092 Indentation of 4 instead of 2 > | raise SystemExit("Could not access bucket!") > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:100 Indentation of 4 instead of 2 > | download(directory) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:102 Indentation of 4 instead of 2 > | if isfile(NEED_TO_UPLOAD_MARKER): # FIXME > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:103 Indentation of 4 instead of 2 > | upload(directory) > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:105 Indentation of 4 instead of 2 > | print("No need to upload anything.") > T100:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:107 Indentation of 4 instead of 2 > | raise SystemExit("Unrecognized mode {!r}".format(mode)) > T802:WARNING 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:064 open() calls should be made within a contextmanager. > | open(NEED_TO_UPLOAD_MARKER, 'a').close() > E501:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:050 line too long (105 > 100 characters) > | run(['tar', '-czf', _tarball_filename_for(directory), '-C', dirname(directory), basename(directory)]) > E501:ERROR 3rdparty/javascript/scheduler/assets/bower_components/bootstrap/test-infra/s3_cache.py:086 line too long (114 > 100 characters) > | raise SystemExit("USAGE: s3_cache.py ") > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)