aurora-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AURORA-414) if thermos_executor_runner exists on $PATH, choose it instead of embedded runner
Date Tue, 13 May 2014 17:48:16 GMT

    [ https://issues.apache.org/jira/browse/AURORA-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996683#comment-13996683
] 

Kevin Sweeney commented on AURORA-414:
--------------------------------------

Have this on a branch from a while ago but never cleaned up the patch

Here's a minimal patch:

{code}
-# TODO(wickman) Consider just having the OSS version require pip installed
-# thermos_runner binaries on every machine and instead of embedding the pex
-# as a resource, shell out to one on the PATH.
 def dump_runner_pex():
+  for p in os.environ.get('PATH', '').split(os.pathsep):
+    runner_file = os.path.join(p, 'thermos_runner')
+    if os.path.exists(runner_file):
+      return runner_file
+
   import pkg_resources
   import apache.aurora.executor.resources
   pex_name = 'thermos_runner.pex'
{code}

> if thermos_executor_runner exists on $PATH, choose it instead of embedded runner
> --------------------------------------------------------------------------------
>
>                 Key: AURORA-414
>                 URL: https://issues.apache.org/jira/browse/AURORA-414
>             Project: Aurora
>          Issue Type: Task
>          Components: Executor, Thermos
>            Reporter: brian wickman
>
> Right now the ThermosTaskRunner in the aurora executor requires the thermos runner to
be embedded as a pex file.  This is not compatible philosophically with the ability to pip
install everything.  If a runner exists on the $PATH, we should use that instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message