aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Donatucci <ndonatu...@medallia.com>
Subject Re: Adding support for Mesos' Kill Policy when running docker executor-less tasks.
Date Tue, 17 Jan 2017 18:32:03 GMT
Hi.

Have there been any news on this issue?

On Thu, Jan 5, 2017 at 7:10 PM, Mauricio Garavaglia <
mauriciogaravaglia@gmail.com> wrote:

> Hi,
>
> Some progress in 'Executor-less docker containers' would be great, in it's
> current form is kind of useless as you can't specify the CMD
> <https://docs.docker.com/engine/reference/builder/#/cmd> to pass to the
> entrypoint. I played with that a bit a while back, but didn't continue
> (sorry) to make the CLI work properly with missing Process; which I think
> is something that John's patch addresses. See
> https://github.com/medallia/aurora/commit/bd5938590fea3a9a7b2db5d2ff8c6c
> d981b0e0c1
>
> The cmd to run was included as part of the Docker container struct like:
> Container(docker = Docker(image = "docker/whalesay", parameters=p,
> command="hello world")))
>
>
>
> On Thu, Jan 5, 2017 at 4:18 PM, Renan DelValle <rdelval1@binghamton.edu>
> wrote:
>
> > I think adding the kill policy to the Thrift API is fine. For the first
> > pass, I don't think it's a big deal to just keep it as a feature in the
> > Thrift API.
> >
> > However, we should also have a discussion on how we should integrate the
> > increasing number of Thrift APIs missing from the main Aurora client.
> (Mea
> > culpa: I'm probably one of the guiltiest parties of neglecting this
> > aspect.)
> >
> > Now that AURORA-1288 has shipped, we should consider reviving discussion
> on
> > John's patch and even extending it.
> >
> > Additional planning is definitely needed IF we plan to integrate (off the
> > top of my head):
> > * Custom Executors (At least rudimentary support, i.e.: Name + Data blob,
> > and also include the command-executor)
> > * Executor-less docker containers
> > * URI Fetcher
> > * Kill Policy
> >
> >
> > On Thu, Jan 5, 2017 at 1:09 PM, Erb, Stephan <
> Stephan.Erb@blue-yonder.com>
> > wrote:
> >
> > > I will try to summarize an off-list discussion so that more people can
> > > participate:
> > >
> > > Aurora has an unofficial way to launch Docker containers without
> Thermos.
> > > Rather than using the Thermos executor, Mesos will directly call the
> > > container entrypoint. This support was contributed by Bill (
> > > https://reviews.apache.org/r/44685/ ). An additional patch by John (
> > > https://reviews.apache.org/r/44745/ ) to expose this functionality
> > within
> > > the client job configuration was discarded due to missing consensus at
> > the
> > > time. This means, the entrypoint mode is only available for REST API
> > users,
> > > and for users with patched clients.
> > >
> > > The goal of Nicolás is now to provide a graceful shutdown for
> containers
> > > running without Thermos. He has prepared a minimal patch that sketches
> > the
> > > idea https://github.com/apache/aurora/compare/master...
> > > medallia:KillPolicyGracePeriod.
> > >
> > > How do we want to proceed here? Do we plan to improve our Docker
> > > entrypoint story? If yes, can we just re-open Johns RB and merge an
> > > extended version of Nicolás change, or do we need some additional
> > planning?
> > >
> > > I am happy to hear what you think.
> > >
> > >
> > > On 29/12/2016, 16:48, "Nicolas Donatucci" <ndonatucci@medallia.com>
> > wrote:
> > >
> > >     Hello everybody.
> > >
> > >     I was thinking on adding support for the current Mesos' Grace
> Period
> > > Kill
> > >     Policy when running Docker containers without Thermos. It is
> > currently
> > > the
> > >     only Kill Policy implemented by Mesos. (More information can be
> found
> > > here
> > >     https://github.com/apache/mesos/blob/master/CHANGELOG#L576-L585
> and
> > > JIRA
> > >     issue here https://issues.apache.org/jira/browse/MESOS-4909)
> > >
> > >     My idea is to add a Kill Policy to TaskConfig in order to pass it
> on
> > to
> > >     Mesos. The "finalization_wait" field of the task schema can be used
> > to
> > >     create the corresponding Kill Policy.
> > >
> > >     What do you think?
> > >
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message