Mailing-List: contact dev-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aurora.apache.org
From: pierrecdn <git@git.apache.org>
To: dev@aurora.apache.org
Reply-To: dev@aurora.apache.org
Message-ID: <git-pr-21-aurora@git.apache.org>
Subject: [GitHub] aurora pull request: Use chmod+x to make termos_runner.pex
 executa...
Content-Type: text/plain
Date: Thu, 10 Mar 2016 15:18:15 +0000 (UTC)

GitHub user pierrecdn opened a pull request:

    https://github.com/apache/aurora/pull/21

    Use chmod+x to make termos_runner.pex executable

    When using `--executor_environment_variables` without explicitely passing LD_LIBRARY_PATH, `sys.executable` returns an empty string resulting in a _'[Errno 13] Permission denied'_ error for every launched task.
    
    Moreover, it seems that this feature is coming in 0.30: "Executors no longer inherit environment variables from the agent".
    
    This patch partially revert back 07ce21d where chmod_x method was removed in favor of using sys.executable.
    
    ---
    
    Please let me know if the patch seems consistent and if I should post a review on apache.org.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/criteo-forks/aurora criteo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aurora/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit 07d71b06245a4a7d5987229fedf8344d1ee0cf78
Author: Pierre Cheynier <p.cheynier@criteo.com>
Date:   2016-03-10T11:25:28Z

    Use chmod+x to make termos_runner.pex executable
    
    When using `--executor_environment_variables` without explicitely
    passing LD_LIBRARY_PATH, `sys.executable` returns an empty string
    resulting in a '[Errno 13] Permission denied' error for every launched
    task.
    
    Moreover, it seems that this feature is coming in 0.30: "Executors no
    longer inherit environment variables from the agent".
    
    This patch partially revert back 07ce21d where chmod_x method was
    removed in favor of using sys.executable.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---