aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Commits without reviews
Date Thu, 24 Dec 2015 16:24:01 GMT
I'm generally ok with this. Just curious: what do you think about maybe
posting a review and then committing it right away in these cases though? A
bit noisy on the reviews@ list, but at least it'd give people a chance to
peruse/comment as they see fit (with the assumption that any comments would
be followed up in a subsequent commit if needed).

On Wed, Dec 23, 2015 at 3:48 PM, Bill Farner <wfarner@apache.org> wrote:

> All,
>
> Over the past few days, i have made several commits to the repository
> without code review.  Our convention has historically been to perform a
> code review for any change, however small.  Please see below for some
> rationale, but i would like to propose that we allow committers to exercise
> judgement on skipping code reviews for changes unrelated to build or test
> of the main project (e.g. scheduler, executor, client, packaging).  What do
> you all think?
>
> As an example, i think the code review process is too much overhead for
> commits like the ones below.  With these commits i was playing whack-a-mole
> to get alignment between markdown rendering on github.com/apache/aurora
> and
> aurora.apache.org.  Skipping code review allowed me to fix things in a
> much
> shorter timeframe.
>
> commit 0d9fe18
> Author: Bill Farner <wfarner@apache.org>
> Date:   Wed Dec 23 08:31:27 2015 -0800
>
>     Fix string interpolation for release email.
>
> commit df5200b
> Author: Bill Farner <wfarner@apache.org>
> Date:   Mon Dec 21 14:19:48 2015 -0800
>
>     Fix formatting and work around anchor link issues in installing.md
>
> commit 21c605e
> Author: Bill Farner <wfarner@apache.org>
> Date:   Mon Dec 21 14:11:10 2015 -0800
>
>     Fix anchor links in installing.md.
>
> commit 9326fa6
> Author: Bill Farner <wfarner@apache.org>
> Date:   Mon Dec 21 12:21:37 2015 -0800
>
>     Link to install guide from docs/README.md
>
> commit f8e59a4
> Author: Bill Farner <wfarner@apache.org>
> Date:   Mon Dec 21 12:12:56 2015 -0800
>
>     Fix formatting issues in installing doc.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message