Mailing-List: contact dev-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aurora.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAMnduq-6D0_50t5N0KfOogeU+Chehffbgpq+JVwqq2_t5YVxeg@mail.gmail.com>
References: 
 <CAMnduq-=G1ZCJhKmk77H2kmtrC9UX92VHCrb9YYFQ2SgSfyfEQ@mail.gmail.com>
	<CAFWq12UduKwPk=9uxTbE_p9Q=iK=CR0B2PRsE6F7Qu3e0gUE3g@mail.gmail.com>
	<CAMnduq-6D0_50t5N0KfOogeU+Chehffbgpq+JVwqq2_t5YVxeg@mail.gmail.com>
Date: Thu, 10 Sep 2015 09:34:35 -0700
Message-ID: 
 <CAOTkfX4HPC8o83OJEx7yruLun8d1hUZVN=ZAj9oQke14DKa-qA@mail.gmail.com>
Subject: Re: Testing our UI code
From: Maxim Khutornenko <maxim@apache.org>
To: dev@aurora.apache.org
Content-Type: text/plain; charset=UTF-8

+1. Thanks for driving this Joshua!

One question: will this effort get us any closer to improving
iteration speed? I.e. not requiring gradle run on a host machine
before jumping into vagrant?

On Thu, Sep 10, 2015 at 9:20 AM, Joshua Cohen <jcohen@twopensource.com> wrote:
> Yes, it should be. I haven't actually verified it myself yet, but based on
> the description of the gradle node.js plugin[1], it seems completely
> painless:
>
> This plugin enables you to run any NodeJS script as part of your build. It
> does not depend on NodeJS (or NPM) being installed on your system. The
> plugin will download and manage NodeJS distributions, unpack them into your
> local .gradle directory and use them from there.
>
> [1] https://github.com/srs/gradle-node-plugin
>
>
> On Thu, Sep 10, 2015 at 11:18 AM, Bill Farner <wfarner@apache.org> wrote:
>
>> I think this is great!  Am i understanding correctly that this will all be
>> self-bootstrapping on dev machines?
>>
>> On Thu, Sep 10, 2015 at 8:44 AM, Joshua Cohen <jcohen@twopensource.com>
>> wrote:
>>
>> > Hi all,
>> >
>> > I recently posted an update on this ticket:
>> > https://issues.apache.org/jira/browse/AURORA-451 describing what I see
>> as
>> > the best way forward to enable tests for our UI code. I figured this
>> > warranted some extra attention so calling it out here as well. To restate
>> > what's in the ticket, I propose the following:
>> >
>> >    - Add gradle nodejs support (
>> https://github.com/srs/gradle-node-plugin
>> > ).
>> >    This lets us use node.js to drive tests but does not require
>> developers
>> >    install node.js manually. The plugin instead manages the node.js
>> install
>> >    for you.
>> >    - Configure karma (
>> >
>> >
>> http://stackoverflow.com/questions/22336537/how-to-run-js-karma-tests-from-gradle
>> > ).
>> >    Karma is a test runner that can launch webdriver tests for testing
>> > angular
>> >    apps in the browser.
>> >    - Write tests (https://docs.angularjs.org/guide/unit-testing). Should
>> >    speak for itself.
>> >
>> > The benefit of using karma/webdriver is that tests will load code the
>> same
>> > way the browser does, so no need to bring in something like
>> > browserify/webpack so that code can be resolved in a node.js environment
>> as
>> > well as in the browser.
>> >
>> > Interested to hear thoughts on this proposal.
>> >
>> > Thanks!
>> >
>> > Joshua
>> >
>>