aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <>
Subject Re: Testing Done in RB?
Date Mon, 23 Feb 2015 18:45:15 GMT
I am +1 on filling the test section as it may be a good indicator of
what testing has been attempted (e.g. java-only, python-only, python
sub-target, vagrant e2e, vagrant manual).

I am -1 on having this included into the commit message as it blows up
the commit message size and makes for a hard to read arbitrary
length/formatted commit. The RB link should be enough to get commit
details and testing done.

On Mon, Feb 23, 2015 at 10:35 AM, Joshua Cohen <> wrote:
> This came up in a review and I figured it'd be better discussed here rather
> than in a review that most folks probably aren't reading.
> Do people find value in this section being filled in? The argument against
> is generally that it's always the same value and if we wait for a ship it
> from ReviewBot we have assurance that everything is kosher. The argument
> for is that it serves as an example for new committers on how to run tests,
> however this was on the assumption that the full commit message from `rbt
> patch` was used. It seems that some people edit the testing done section
> out before merging commits from RB(?).
> Thoughts?
> Cheers,
> Joshua

View raw message