aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@twopensource.com>
Subject Testing Done in RB?
Date Mon, 23 Feb 2015 18:35:48 GMT
This came up in a review and I figured it'd be better discussed here rather
than in a review that most folks probably aren't reading.

Do people find value in this section being filled in? The argument against
is generally that it's always the same value and if we wait for a ship it
from ReviewBot we have assurance that everything is kosher. The argument
for is that it serves as an example for new committers on how to run tests,
however this was on the assumption that the full commit message from `rbt
patch` was used. It seems that some people edit the testing done section
out before merging commits from RB(?).

Thoughts?

Cheers,

Joshua

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message