Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 438D217CAF for ; Tue, 7 Oct 2014 00:55:52 +0000 (UTC) Received: (qmail 78479 invoked by uid 500); 7 Oct 2014 00:55:51 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 78429 invoked by uid 500); 7 Oct 2014 00:55:51 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 78418 invoked by uid 99); 7 Oct 2014 00:55:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 00:55:51 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 07 Oct 2014 00:55:50 +0000 Received: (qmail 77468 invoked by uid 99); 7 Oct 2014 00:55:30 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 00:55:30 +0000 Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id DB75D1A0692 for ; Tue, 7 Oct 2014 00:55:28 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id hi2so6316581wib.3 for ; Mon, 06 Oct 2014 17:55:26 -0700 (PDT) X-Gm-Message-State: ALoCoQnmideWRhZWwBZOyHPHnDxV/D+RpV4BOPcGv5B473BI2Pw/jh14OMPN1IK8SXI43G0Qoflf MIME-Version: 1.0 X-Received: by 10.180.80.198 with SMTP id t6mr425208wix.6.1412643326849; Mon, 06 Oct 2014 17:55:26 -0700 (PDT) Received: by 10.216.113.74 with HTTP; Mon, 6 Oct 2014 17:55:26 -0700 (PDT) In-Reply-To: References: Date: Mon, 6 Oct 2014 17:55:26 -0700 Message-ID: Subject: Re: Removing Aurora's special handling of the 'rack' attribute From: Kevin Sweeney To: Aurora Content-Type: multipart/alternative; boundary=f46d044287eeb112610504caa731 X-Virus-Checked: Checked by ClamAV on apache.org --f46d044287eeb112610504caa731 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable This ticket (5 watchers and 2 votes) suggests demand exists: https://issues.apache.org/jira/browse/AURORA-174 On Mon, Oct 6, 2014 at 5:47 PM, Zameer Manji wrote: > I haven't done it all at once because I haven't seen any demand for > removing the 'host' attribute. If you (or other people) disagree, I can > remove both special cases in one go. > > On Mon, Oct 6, 2014 at 5:37 PM, Kevin Sweeney wrote: > > > Why not take it all at once and avoid the need for 2 deprecation cycles= ? > > With that change folks with existing Mesos clusters would be able to > deploy > > Aurora without changing the attributes flag on every slave (which > requires > > rebooting the entire cluster to take effect). > > > > On Mon, Oct 6, 2014 at 5:24 PM, Zameer Manji > > wrote: > > > > > I currently don't plan on removing 'host' right now or in the future. > If > > > there is a need to remove it I would prefer to tackle it later. > > > > > > On Mon, Oct 6, 2014 at 5:13 PM, Kevin Sweeney > > wrote: > > > > > > > Will 'host' be deprecated as well? > > > > > > > > On Mon, Oct 6, 2014 at 4:30 PM, Zameer Manji < > zmanji@twopensource.com> > > > > wrote: > > > > > > > > > I have put up a review whic= h > > > > removes > > > > > the special casing and handling of the =E2=80=98rack=E2=80=99 con= straint. This is a > > > > > breaking change because Aurora will no longer inject a rack > > constraint > > > > of 1 > > > > > if a job omits a rack constraint value. However this means that > > Aurora > > > > will > > > > > be able to schedule jobs on to slaves which don=E2=80=99t have th= e =E2=80=98rack=E2=80=99 > > > > attribute > > > > > and slaves that want to accept tasks from Aurora don=E2=80=99t ne= ed to have > > the > > > > > =E2=80=98rack=E2=80=99 attribute set. > > > > > > > > > > Before the next release of Aurora (0.6.0) you should check if you > are > > > > > relying on the injected value for scheduling decisions and if so > > > > explicitly > > > > > encode a rack limit of 1 in the job's aurora config. > > > > > =E2=80=8B > > > > > -- > > > > > Zameer Manji > > > > > > > > > > > > > > > > > > > > > -- > > > Zameer Manji > > > > > > > > > -- > Zameer Manji > --f46d044287eeb112610504caa731--