aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Sweeney <kevi...@apache.org>
Subject Re: Committers: Please help keep the git log clean
Date Wed, 05 Feb 2014 20:09:21 GMT
Don't forget that the workflow is somewhat documented at
https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=blob;f=docs/contributing.md;h=434116378711f40877f6f7af15af8545b5335ec0;hb=HEAD

Patches to clarify are appreciated!


On Wed, Feb 5, 2014 at 12:02 PM, Bill Farner <wfarner@apache.org> wrote:

> Good point!  Our commit workflow sidesteps the merge commit issue (we grab
> the patch from reviewboard and apply that to master in an atomic commit).
>  I'm *hoping* at some point we can formalize these expectations with a hook
> on the git server.
>
> -=Bill
>
>
> On Wed, Feb 5, 2014 at 11:12 AM, Henry Saputra <henry.saputra@gmail.com
> >wrote:
>
> > Dont forget to use git rebase instead of git pull =)
> >
> > - Henry
> >
> > On Tue, Feb 4, 2014 at 1:53 PM, Bill Farner <wfarner@apache.org> wrote:
> > > First and foremost, please don't take committing on master lightly.
> >  Every
> > > time you commit and push to master, i encourage you to triple-check
> your
> > > commit message, and run the build one last time.  Remember, *once
> you've
> > > pushed to master, it's there forever*.
> > >
> > > Unfortunately we have some manual lint steps, which will hopefully be
> > > automated in the near future:
> > >
> > > - Wrap your commit message at 100 cols.
> > >
> > > - Remove any redundancy in the commit message (e.g. rbt pulls the
> summary
> > > and description, which often overlap)
> > >
> > > - Keep the commit message at a sane length.  The "Testing Done" section
> > is
> > > rarely interesting, and should not include lengthy terminal output.
> > >
> > >
> > > Thanks!
> > >
> > > -=Bill
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message