Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92F9F105B8 for ; Fri, 17 Jan 2014 20:31:47 +0000 (UTC) Received: (qmail 68858 invoked by uid 500); 17 Jan 2014 20:31:46 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 68804 invoked by uid 500); 17 Jan 2014 20:31:45 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 68793 invoked by uid 99); 17 Jan 2014 20:31:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 20:31:45 +0000 X-ASF-Spam-Status: No, hits=-2000.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 17 Jan 2014 20:31:42 +0000 Received: (qmail 68459 invoked by uid 99); 17 Jan 2014 20:31:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 20:31:20 +0000 Date: Fri, 17 Jan 2014 20:31:20 +0000 (UTC) From: "Hudson (JIRA)" To: dev@aurora.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AURORA-42) Modify client side code to distinguish between api objects MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AURORA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875235#comment-13875235 ] Hudson commented on AURORA-42: ------------------------------ SUCCESS: Integrated in Aurora #55 (See [https://builds.apache.org/job/Aurora/55/]) Revert "Get rid of ambiguities about exactly what object is being used to send calls to the scheduler. (See AURORA-42)." (mchucarroll: rev 813bfc2bfb54a56c5e9a03dcfefb3271ecce1790) * src/test/python/apache/aurora/client/api/test_job_monitor.py * src/test/python/apache/aurora/client/commands/test_status.py * src/test/python/apache/aurora/client/commands/test_cancel_update.py * src/test/python/apache/aurora/client/commands/test_restart.py * src/main/python/apache/aurora/client/api/job_monitor.py * src/test/python/apache/aurora/client/cli/test_create.py * src/test/python/apache/aurora/client/cli/util.py * src/test/python/apache/aurora/client/cli/test_kill.py * src/main/python/apache/aurora/client/api/__init__.py * src/main/python/apache/aurora/client/api/scheduler_client.py * src/test/python/apache/aurora/client/commands/test_create.py * src/test/python/apache/aurora/client/commands/test_ssh.py * src/test/python/apache/aurora/client/cli/test_diff.py * src/test/python/apache/aurora/client/cli/test_status.py * src/test/python/apache/aurora/client/commands/test_listjobs.py * src/test/python/apache/aurora/client/commands/test_diff.py * src/test/python/apache/aurora/client/commands/test_kill.py * src/test/python/apache/aurora/client/commands/test_run.py * src/test/python/apache/aurora/client/commands/util.py * src/test/python/apache/aurora/client/commands/test_update.py * src/main/python/apache/aurora/client/commands/core.py > Modify client side code to distinguish between api objects > ---------------------------------------------------------- > > Key: AURORA-42 > URL: https://issues.apache.org/jira/browse/AURORA-42 > Project: Aurora > Issue Type: Task > Components: Client > Reporter: Mark Chu-Carroll > Assignee: Mark Chu-Carroll > > In client work, especially writing tests, the term "scheduler" is overloaded in the code, and this makes diagnosing and debugging failures difficult. > An aurora API object contains a property named "scheduler", which is a reference to a SchedulerProxy. A SchedulerProxy, in turn, contains a property named "scheduler", which is actually a reference to a SchedulerClient. > As a result, code frequently reads "foo. scheduler.scheduler.something"; in tests, when you see a "scheduler" parameter, it's either a SchedulerProxy or a SchedulerClient, with no good way to distinguish. This is especially problematic when you see a test failure: foo. scheduler didn't get an expected call; what is foo.scheduler? > To clear this mess up, we should get rid of the "scheduler" fields, and rename them to make clear what they are: api contains a field "scheduler_proxy"; SchedulerProxy contains a field "scheduler_client". -- This message was sent by Atlassian JIRA (v6.1.5#6160)