Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2859C106AE for ; Fri, 3 Jan 2014 20:35:31 +0000 (UTC) Received: (qmail 43714 invoked by uid 500); 3 Jan 2014 20:35:31 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 43686 invoked by uid 500); 3 Jan 2014 20:35:31 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 43678 invoked by uid 99); 3 Jan 2014 20:35:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jan 2014 20:35:31 +0000 X-ASF-Spam-Status: No, hits=-1998.2 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 03 Jan 2014 20:35:29 +0000 Received: (qmail 43615 invoked by uid 99); 3 Jan 2014 20:35:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jan 2014 20:35:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1BAEC1D40F0; Fri, 3 Jan 2014 20:35:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0062038877436568562==" MIME-Version: 1.0 Subject: Re: Review Request 16444: Client side changes for the client quota check. From: "Maxim Khutornenko" To: "Bill Farner" , "Brian Wickman" , "Mark Chu-Carroll" Cc: "Maxim Khutornenko" , "Aurora" Date: Fri, 03 Jan 2014 20:35:07 -0000 Message-ID: <20140103203507.29218.52382@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/16444/ X-Sender: "Maxim Khutornenko" References: <20140103012348.29218.53336@reviews.apache.org> In-Reply-To: <20140103012348.29218.53336@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0062038877436568562== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16444/ ----------------------------------------------------------- (Updated Jan. 3, 2014, 8:35 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Changes ------- CR comments addressed. Repository: aurora Description ------- Quota checks should be done outside of populateJobConfig(). This is needed to properly account for the released resources to prevent failures in job updates approaching their quota limits. Part 1: schema and client related changes. Diffs (updated) ----- src/main/python/apache/aurora/client/api/BUILD 9af74e9746500e7b388fc0b7fe7186fca0daefd3 src/main/python/apache/aurora/client/api/quota_check.py PRE-CREATION src/main/python/apache/aurora/client/api/updater.py e364f26005d5194f2c8fea8c267fe2708c59d50b src/main/python/apache/aurora/client/commands/BUILD 556d00aab633106a98cbfb4b1ee2d8e755627c04 src/main/python/apache/aurora/client/commands/core.py 45204b58ed14fdb83d31afe0fa4598f1b539062b src/main/thrift/org/apache/aurora/gen/api.thrift 480b8f472bcfbe547a91c41638250350a0110334 src/test/python/apache/aurora/client/api/BUILD c5326752c9841a3f3cb8c9cc57f29f675e345788 src/test/python/apache/aurora/client/api/test_quota_check.py PRE-CREATION src/test/python/apache/aurora/client/api/test_updater.py 5843bb4d3698abc5c4a48ee6eaf2be85e9415a06 src/test/python/apache/aurora/client/commands/test_update.py ccc3ee9d97de4373b05ad2de8d88939510c2f052 Diff: https://reviews.apache.org/r/16444/diff/ Testing ------- ./pants src/test/python/twitter/aurora/client:all Thanks, Maxim Khutornenko --===============0062038877436568562==--