Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44D6810258 for ; Fri, 3 Jan 2014 02:36:48 +0000 (UTC) Received: (qmail 5858 invoked by uid 500); 3 Jan 2014 02:36:48 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 5838 invoked by uid 500); 3 Jan 2014 02:36:48 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 5829 invoked by uid 99); 3 Jan 2014 02:36:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jan 2014 02:36:48 +0000 X-ASF-Spam-Status: No, hits=-1998.2 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 03 Jan 2014 02:36:44 +0000 Received: (qmail 5528 invoked by uid 99); 3 Jan 2014 02:36:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jan 2014 02:36:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 45A8E1D4113; Fri, 3 Jan 2014 02:36:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4167242836867886954==" MIME-Version: 1.0 Subject: Re: Review Request 16575: Replace StorageStarted event with TaskStateChange events. From: "Maxim Khutornenko" To: "Maxim Khutornenko" , "Suman Karumuri" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Fri, 03 Jan 2014 02:36:20 -0000 Message-ID: <20140103023620.26158.67717@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/16575/ X-Sender: "Maxim Khutornenko" References: <20140103001016.29218.72463@reviews.apache.org> In-Reply-To: <20140103001016.29218.72463@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4167242836867886954== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16575/#review31103 ----------------------------------------------------------- Ship it! src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java IDEA formatting? - Maxim Khutornenko On Jan. 3, 2014, 12:10 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16575/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 12:10 a.m.) > > > Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > This change makes it easier to consume events about the state of tasks. Previously, ~every consumer of TaskStateChange needed to know to also consume StorageStarted and query the full storage. The new change makes TaskStateChange more intuitive and therefore less error-prone. > > A big side-effect of this change is that several classes no longer need to worry about or query Storage. > > Changes of note: > > - Most critical change is in CallOrderEnforcingStorage, which now sends a slew of TaskStateChange notifications instead of StorageStarted. This has a ripple for event consumers. > - NotifyingMethodInterceptor was removed, as it was easily replaced by more readable and concise code. > - Introduced EventSink interface to replace the ambiguous Closure binding. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 4323fa4672589ae6493692dea5beefb3b5484487 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1ba81d49e7e8886ee57a360ede829a2ef286cd59 > src/main/java/org/apache/aurora/scheduler/TaskVars.java 6c35bfb762f2eb09ff1c962abb645fc8ce91c3f9 > src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 6c35ab668fbdfa8a9d02639c811c3203d40033e9 > src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 92fdf35fff1a7993dd8aac4b3fc69f738d1f726a > src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java bea1bfe32300ef54774fcd6a5b82c757425533a9 > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 7a09d1e34ee309308ff714bb56c6891b012165bd > src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java c2a7704f01f1b72d70f63559528aac193f1fd897 > src/main/java/org/apache/aurora/scheduler/events/EventSink.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptor.java e5ddad0426b54d2eb620beafeb66b5f15999361b > src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java ca9ed10d7c4b9b796b1d0cc124e665b3690ebd4f > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 971f40c9dba872fd52042a48a3090ebaf09b990f > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 94ca02ad425ea67787149ae8733b19c0fea325ab > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 86ccd6e4afc74b50a1cf56f9e156b4e1723c1c7d > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java c7d87ffabcd9745559458b2e22655e199fc708f5 > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java e0bfb1e44f3cfda740bf48b78a5f6f023b8849bc > src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java f710cac6ff6d40122e04c486d4871981d889ad3f > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java b6db6c08181b15ee18ddc60cbcb15fb5957bed61 > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 00425391b644fe5d432890e5906592f76b57dc12 > src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 7527ed804e32442fa8c5ae23ed6021bf913df8b5 > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 3f4adfa9abdc4f895f42039f60da1657bee8aef7 > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 8fe55c1741b2c1a1f0ec0fbdcbd8e48d91131d87 > src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java 3e9309409643f0e91dd7da0e1019ec98f0fa21d3 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 350dd07abe8588562cf9aa3da32ad1c7f21936f8 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 1b0548730e44b144957ecc888cea95ff66123c1e > src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 70f47c4f12e48b2d32f838bc00a132d102bc64f5 > src/test/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptorTest.java 824b0f23b426d8ebc2c8255e1456afe73d9fbdab > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java efa8ed4b85c5b5500359e9b18e70e13d73f2616b > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 05148ae2964c4898f2077b211000529907535d18 > src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java aa4818657d2d87328292fe8288a98b1b254cc6c0 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java d5627b216f01b554a9cf4497543006a36f839021 > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 005814b1ab289c254c29a32442deae120f10af23 > src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 0f2982553c20e413d3866cf077538d2d49624e8e > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 122cb67a9d82a0049b031ffc1d2c2522347221fc > > Diff: https://reviews.apache.org/r/16575/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > > --===============4167242836867886954==--