aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@gmail.com>
Subject Re: Review Request 16306: "job status" command, with wildcard support.
Date Fri, 03 Jan 2014 21:47:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31166
-----------------------------------------------------------



src/main/python/twitter/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59544>

    I think this check is not quite right.  It should be more like:
    
    return not any('*' in component for component in (key.cluster, key.role, key.env, key.name))
    
    



src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59546>

    strip off all the \n\t's and do '\n\t'.join(...) ?



src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59547>

    use list(filter(...)) or []-comprehension here since filter() is lazy in python3, so len()
won't work on it.  (render_tasks_pretty calls len() on the iterable)


- Brian Wickman


On Dec. 18, 2013, 9:27 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2013, 9:27 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added an implementation of the "status" verb for jobs. This is the first command to use
the new job wildcards, so there's a bunch of infrastructure added to the Context to support
it.
> 
> This also includes unit tests of the new command.
> 
> 
> Diffs
> -----
> 
>   src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8

>   src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8

>   src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266

>   src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9

>   src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3

>   src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c

>   src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a

>   src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf

>   src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a

> 
> Diff: https://reviews.apache.org/r/16306/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message