aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 16575: Replace StorageStarted event with TaskStateChange events.
Date Thu, 02 Jan 2014 21:19:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16575/#review31065
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java
<https://reviews.apache.org/r/16575/#comment59406>

    This wording is a bit confusing to me - does this mean both the storage is ready and the
driver is connected? Or just that backfill has finished? What do you think about reusing the
terminology from the scheduler state machine?


- Kevin Sweeney


On Jan. 2, 2014, 1:01 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16575/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2014, 1:01 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change makes it easier to consume events about the state of tasks.  Previously,
~every consumer of TaskStateChange needed to know to also consume StorageStarted and query
the full storage.  The new change makes TaskStateChange more intuitive and therefore less
error-prone.
> 
> A big side-effect of this change is that several classes no longer need to worry about
or query Storage.
> 
> Changes of note:
> 
> - Most critical change is in CallOrderEnforcingStorage, which now sends a slew of TaskStateChange
notifications instead of StorageStarted.  This has a ripple for event consumers.
> - NotifyingMethodInterceptor was removed, as it was easily replaced by more readable
and concise code.
> - Introduced EventSink interface to replace the ambiguous Closure<PubsubEvent>
binding.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 4323fa4672589ae6493692dea5beefb3b5484487

>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 1ba81d49e7e8886ee57a360ede829a2ef286cd59

>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 6c35bfb762f2eb09ff1c962abb645fc8ce91c3f9

>   src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 6c35ab668fbdfa8a9d02639c811c3203d40033e9

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java bea1bfe32300ef54774fcd6a5b82c757425533a9

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 7a09d1e34ee309308ff714bb56c6891b012165bd

>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java c2a7704f01f1b72d70f63559528aac193f1fd897

>   src/main/java/org/apache/aurora/scheduler/events/EventSink.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptor.java e5ddad0426b54d2eb620beafeb66b5f15999361b

>   src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java ca9ed10d7c4b9b796b1d0cc124e665b3690ebd4f

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 971f40c9dba872fd52042a48a3090ebaf09b990f

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 94ca02ad425ea67787149ae8733b19c0fea325ab

>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 86ccd6e4afc74b50a1cf56f9e156b4e1723c1c7d

>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java c7d87ffabcd9745559458b2e22655e199fc708f5

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java e0bfb1e44f3cfda740bf48b78a5f6f023b8849bc

>   src/main/java/org/apache/aurora/scheduler/state/SideEffectStorage.java f710cac6ff6d40122e04c486d4871981d889ad3f

>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java b6db6c08181b15ee18ddc60cbcb15fb5957bed61

>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 00425391b644fe5d432890e5906592f76b57dc12

>   src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 7527ed804e32442fa8c5ae23ed6021bf913df8b5

>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 3f4adfa9abdc4f895f42039f60da1657bee8aef7

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 8fe55c1741b2c1a1f0ec0fbdcbd8e48d91131d87

>   src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java 3e9309409643f0e91dd7da0e1019ec98f0fa21d3

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 350dd07abe8588562cf9aa3da32ad1c7f21936f8

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 1b0548730e44b144957ecc888cea95ff66123c1e

>   src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 70f47c4f12e48b2d32f838bc00a132d102bc64f5

>   src/test/java/org/apache/aurora/scheduler/events/NotifyingMethodInterceptorTest.java
824b0f23b426d8ebc2c8255e1456afe73d9fbdab 
>   src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
efa8ed4b85c5b5500359e9b18e70e13d73f2616b 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 05148ae2964c4898f2077b211000529907535d18

>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java aa4818657d2d87328292fe8288a98b1b254cc6c0

>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java d5627b216f01b554a9cf4497543006a36f839021

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
005814b1ab289c254c29a32442deae120f10af23 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 0f2982553c20e413d3866cf077538d2d49624e8e

>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 122cb67a9d82a0049b031ffc1d2c2522347221fc

> 
> Diff: https://reviews.apache.org/r/16575/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message