aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 16311: Fixing updater diff.
Date Thu, 02 Jan 2014 20:57:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16311/
-----------------------------------------------------------

(Updated Jan. 2, 2014, 8:57 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
-------

Updated with CR comments.


Repository: aurora


Description
-------

Hopefully fixing the thrift object diff once an for all. Instead of sorting __dict__ that
proved to not cover all cases, converting thrift to sorted tuples via json serialization.


Diffs (updated)
-----

  src/main/python/twitter/aurora/client/api/updater.py 6e8e8a9fdfcf63a8fe0558d5ac36298601fd0552

  src/test/python/twitter/aurora/client/api/test_updater.py ae4de2b57be16f8daf030210abda1ba05f9f30a0


Diff: https://reviews.apache.org/r/16311/diff/


Testing
-------

./pants src/test/python/twitter/aurora/client/api:updater


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message