Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3529567386664106446=="
MIME-Version: 1.0
Subject: Re: Review Request 16353: Skip building the Apache Thrift 0.9.1 tests
From: "Zameer Manji" <zmanji@twopensource.com>
To: "Bill Farner" <wfarner@apache.org>
Cc: "Aurora" <dev@aurora.incubator.apache.org>,
 "Zameer Manji" <zmanji@twopensource.com>,
 "Jake Farrell" <jfarrell@apache.org>
Date: Wed, 18 Dec 2013 18:43:57 -0000
Message-ID: <20131218184357.2160.48019@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Zameer Manji" <noreply@reviews.apache.org>
References: <20131218171946.2160.40314@reviews.apache.org>
In-Reply-To: <20131218171946.2160.40314@reviews.apache.org>
Reply-To: "Zameer Manji" <zmanji@twopensource.com>

--===============3529567386664106446==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16353/#review30624
-----------------------------------------------------------

Ship it!


LGTM

- Zameer Manji


On Dec. 18, 2013, 9:19 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16353/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2013, 9:19 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-7
>     https://issues.apache.org/jira/browse/AURORA-7
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-7: Setup jenkins job
> 
> Skips building the Apache Thrift 0.9.1 tests which have a known issue with libtool.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/Makefile 56e28fd5e12e1cb3363e265012e9cc04ce02bb38 
> 
> Diff: https://reviews.apache.org/r/16353/diff/
> 
> 
> Testing
> -------
> 
> Build initially fails due to: 
> 
> make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/Aurora/build-support/thrift/thrift-0.9.1/test/cpp'
> Makefile:832: warning: overriding commands for target `gen-cpp/ThriftTest.cpp'
> Makefile:829: warning: ignoring old commands for target `gen-cpp/ThriftTest.cpp'
> /bin/bash ../../libtool --tag=CXX   --mode=link g++ -Wall -g -O2 -L/usr/lib   -o libtestgencpp.la  ThriftTest_constants.lo ThriftTest_types.lo ../../lib/cpp/libthrift.la -lssl -lcrypto -lrt -lpthread 
> libtool: link: ar cru .libs/libtestgencpp.a .libs/ThriftTest_constants.o .libs/ThriftTest_types.o 
> ar: .libs/ThriftTest_constants.o: No such file or directory
> 
> 
> Compiled with patch:
> 
> libtool: link: g++ -Wall -g -O2 -o .libs/TutorialServer CppServer.o  -L/usr/lib ./.libs/libtutorialgencpp.a /home/jenkins/jenkins-slave/workspace/Aurora/build-support/thrift/thrift-0.9.1/lib/cpp/.libs/libthrift.so ../../lib/cpp/.libs/libthrift.so -lssl -lcrypto -lrt -lpthread
> g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I../../lib/cpp/src -Igen-cpp -I/usr/include   -Wall -g -O2 -MT CppClient.o -MD -MP -MF .deps/CppClient.Tpo -c -o CppClient.o CppClient.cpp
> mv -f .deps/CppClient.Tpo .deps/CppClient.Po
> /bin/bash ../../libtool --tag=CXX   --mode=link g++ -Wall -g -O2 -L/usr/lib   -o TutorialClient CppClient.o libtutorialgencpp.la ../../lib/cpp/libthrift.la -lssl -lcrypto -lrt -lpthread 
> libtool: link: g++ -Wall -g -O2 -o .libs/TutorialClient CppClient.o  -L/usr/lib ./.libs/libtutorialgencpp.a /home/jenkins/jenkins-slave/workspace/Aurora/build-support/thrift/thrift-0.9.1/lib/cpp/.libs/libthrift.so ../../lib/cpp/.libs/libthrift.so -lssl -lcrypto -lrt -lpthread
> 
> jenkins@minerva:~/jenkins-slave/workspace/Aurora/build-support/thrift$ ./thrift-0.9.1/compiler/cpp/thrift --version
> Thrift version 0.9.1
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


--===============3529567386664106446==--