Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52410106B0 for ; Tue, 17 Dec 2013 01:25:37 +0000 (UTC) Received: (qmail 23565 invoked by uid 500); 17 Dec 2013 01:25:37 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 23543 invoked by uid 500); 17 Dec 2013 01:25:37 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 23534 invoked by uid 99); 17 Dec 2013 01:25:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2013 01:25:37 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 17 Dec 2013 01:25:34 +0000 Received: (qmail 23500 invoked by uid 99); 17 Dec 2013 01:25:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2013 01:25:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B8FAC1D3F60; Tue, 17 Dec 2013 01:25:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0029327778800220861==" MIME-Version: 1.0 Subject: Re: Review Request 16247: Adding random jitter for the initial GC task scheduling to better spread GC execution over time. From: "Bill Farner" To: "Bill Farner" , "Kevin Sweeney" Cc: "Maxim Khutornenko" , "Aurora" Date: Tue, 17 Dec 2013 01:25:11 -0000 Message-ID: <20131217012511.27244.21200@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/16247/ X-Sender: "Bill Farner" References: <20131216180604.9526.16178@reviews.apache.org> In-Reply-To: <20131216180604.9526.16178@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0029327778800220861== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/#review30511 ----------------------------------------------------------- src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java Without a remove(), this now stands out as a memory leak. We either need to remove() at some point or revert to Cache (preferably not relying on the map view of it). - Bill Farner On Dec. 16, 2013, 6:06 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16247/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 6:06 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Modified PulseMonitor to support random initial jitter delay. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java e31ce3d71c895f43ff73ad8e904124443ebdd72a > src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java bd7929d631cf45b4c2c7f39177bbafbd8f659071 > src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java 5a8e13f0d719052286a7136707d7ed1aca87bab2 > src/test/java/com/twitter/aurora/scheduler/PulseMonitorImplTest.java PRE-CREATION > src/test/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncherTest.java ac5e3102925e2f26a12e18e95817403d18e25cb3 > > Diff: https://reviews.apache.org/r/16247/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > > --===============0029327778800220861==--