Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C0A010140 for ; Mon, 16 Dec 2013 23:04:41 +0000 (UTC) Received: (qmail 5246 invoked by uid 500); 16 Dec 2013 23:04:41 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 5223 invoked by uid 500); 16 Dec 2013 23:04:41 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 5215 invoked by uid 99); 16 Dec 2013 23:04:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Dec 2013 23:04:41 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 16 Dec 2013 23:04:38 +0000 Received: (qmail 5044 invoked by uid 99); 16 Dec 2013 23:04:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Dec 2013 23:04:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C55BA1D3F46; Mon, 16 Dec 2013 23:04:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1601720417504043502==" MIME-Version: 1.0 Subject: Re: Review Request 16232: Add offer reservations to preemption flow From: "Zameer Manji" To: "Bill Farner" , "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Aurora" , "Zameer Manji" Date: Mon, 16 Dec 2013 23:04:15 -0000 Message-ID: <20131216230415.27244.25320@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/16232/ X-Sender: "Zameer Manji" References: <20131216202449.11662.18212@reviews.apache.org> In-Reply-To: <20131216202449.11662.18212@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1601720417504043502== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16232/ ----------------------------------------------------------- (Updated Dec. 16, 2013, 3:04 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Changes ------- Addressed all of the feedback. Bugs: AURORA-11 https://issues.apache.org/jira/browse/AURORA-11 Repository: aurora Description ------- This patch adds a reservation system the preemption flow. The reservation associates a slave id with a task id for a fixed duration. If the task attempts to schedule itself during that time period and an offer is available from that slave then it will be scheduled. If another task attempts to schedule itself then it will not use the reserved offer. Diffs (updated) ----- src/main/java/com/twitter/aurora/scheduler/async/AsyncModule.java db07841543e554e269f6fe7b36d7f7232af21140 src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java e5aeb8321e22c51eb3a5dad3d3dd1e26b7121b7d src/main/java/com/twitter/aurora/scheduler/async/TaskGroups.java f95f719c5a444b0f8faa4330852e251dd5de528e src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java fbd82ff70235294cfd27c242f141a585d6bb2396 src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerImplTest.java PRE-CREATION src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d src/test/java/com/twitter/aurora/scheduler/state/PubsubTestUtil.java f9d7fb64728008d0ea6eb424283b58e956e1d50a Diff: https://reviews.apache.org/r/16232/diff/ Testing ------- ./gradlew clean build Thanks, Zameer Manji --===============1601720417504043502==--