Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E2B2106FA for ; Fri, 13 Dec 2013 22:16:02 +0000 (UTC) Received: (qmail 7992 invoked by uid 500); 13 Dec 2013 22:16:02 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 7970 invoked by uid 500); 13 Dec 2013 22:16:02 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 7962 invoked by uid 99); 13 Dec 2013 22:16:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2013 22:16:02 +0000 X-ASF-Spam-Status: No, hits=-1997.9 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 13 Dec 2013 22:16:01 +0000 Received: (qmail 7863 invoked by uid 99); 13 Dec 2013 22:15:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2013 22:15:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 22A171D3EFA; Fri, 13 Dec 2013 22:15:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0206855993330394312==" MIME-Version: 1.0 Subject: Re: Review Request 16163: Added extra_modules option to Scheduler. From: "Suman Karumuri" To: "Bill Farner" , "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Aurora" , "Suman Karumuri" Date: Fri, 13 Dec 2013 22:15:40 -0000 Message-ID: <20131213221540.15782.86933@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/16163/ X-Sender: "Suman Karumuri" References: <20131211015952.6673.83917@reviews.apache.org> In-Reply-To: <20131211015952.6673.83917@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0206855993330394312== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java, line 141 > > > > > > please drop QUOTA from here, as i'm pulling that out in a separate review I was planning to merge later, but since I have to move repos anyways, did it now. Done. > On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/app/Modules.java, line 1 > > > > > > please add license header. i suggest you go ahead and configure intellij to fill it in for you (search for 'template' in the preferences search bar). Done. Thanks. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16163/#review30169 ----------------------------------------------------------- On Dec. 10, 2013, 8:48 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16163/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 8:48 p.m.) > > > Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Added extra_modules option to Scheduler. > > Already have ship it on this in the internal repo. Sending it for review again to check it in. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d > > Diff: https://reviews.apache.org/r/16163/diff/ > > > Testing > ------- > > gradle clean build. > > > Thanks, > > Suman Karumuri > > --===============0206855993330394312==--