Return-Path: X-Original-To: apmail-aurora-dev-archive@minotaur.apache.org Delivered-To: apmail-aurora-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B1C610F76 for ; Fri, 13 Dec 2013 01:30:23 +0000 (UTC) Received: (qmail 56689 invoked by uid 500); 13 Dec 2013 01:30:23 -0000 Delivered-To: apmail-aurora-dev-archive@aurora.apache.org Received: (qmail 56663 invoked by uid 500); 13 Dec 2013 01:30:23 -0000 Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@aurora.incubator.apache.org Delivered-To: mailing list dev@aurora.incubator.apache.org Received: (qmail 56655 invoked by uid 99); 13 Dec 2013 01:30:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2013 01:30:23 +0000 X-ASF-Spam-Status: No, hits=-1997.9 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 13 Dec 2013 01:30:21 +0000 Received: (qmail 56156 invoked by uid 99); 13 Dec 2013 01:30:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2013 01:30:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E16B31D3EA8; Fri, 13 Dec 2013 01:30:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4940211105215226898==" MIME-Version: 1.0 Subject: Re: Review Request 16228: Pin master to -SNAPSHOT and -dev versions. From: "Kevin Sweeney" To: "Bill Farner" , "Zameer Manji" , "Brian Wickman" Cc: "Aurora" , "Kevin Sweeney" Date: Fri, 13 Dec 2013 01:30:00 -0000 Message-ID: <20131213013000.2213.26424@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/16228/ X-Sender: "Kevin Sweeney" References: <20131213004004.2213.76618@reviews.apache.org> In-Reply-To: <20131213004004.2213.76618@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4940211105215226898== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 12, 2013, 4:40 p.m., Brian Wickman wrote: > > src/main/python/twitter/aurora/client/BUILD, line 71 > > > > > > To stay consistent, let's call these 0.2.0-snapshot. Done. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16228/#review30313 ----------------------------------------------------------- On Dec. 12, 2013, 5:27 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16228/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 5:27 p.m.) > > > Review request for Aurora, Bill Farner, Brian Wickman, and Zameer Manji. > > > Bugs: AURORA-10 > https://issues.apache.org/jira/browse/AURORA-10 > > > Repository: aurora > > > Description > ------- > > Pin master to -SNAPSHOT and -dev versions. > > This ensures that we don't inadvertendly publish artifacts that aren't > the final tagged version. A future review will introduce tooling to > automatically and atomically increment these version numbers. > > > Diffs > ----- > > .auroraversion PRE-CREATION > build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 > src/main/python/twitter/aurora/client/BUILD a96a801042c2f3d523ee58645a077e47ce9eac38 > src/main/python/twitter/aurora/config/BUILD 0462158357730865387d0ead001077f39bba6dcb > src/main/python/twitter/aurora/executor/BUILD 02d34f0354e1452731353bd43e43eed9d034398a > src/main/python/twitter/thermos/BUILD 7c5d760c863c2f56d6518a0fbb01aa361c0e6db2 > src/main/python/twitter/thermos/common/BUILD 38de710368dfff46f1dae6df1b878e3d81eb28d3 > src/main/python/twitter/thermos/config/BUILD 7b889d28d13126c4f003c87c7853a0e9ed4e82a5 > src/main/python/twitter/thermos/core/BUILD 014b1f7fa3cc45661c194ae8256fe9767530c3b3 > src/main/python/twitter/thermos/monitoring/BUILD 8601c4eae76aad380274076e7df088c1e8d33ba3 > src/main/python/twitter/thermos/observer/BUILD 090d3ad33083d5ea51a34af29412134afddcc9e2 > src/main/thrift/com/twitter/aurora/gen/BUILD a21f2fc796871ff74b1af4852ec298d75458d442 > src/main/thrift/com/twitter/thermos/BUILD c224d8d5e87f05ea37ac8ecc4ba223228a32b8a5 > > Diff: https://reviews.apache.org/r/16228/diff/ > > > Testing > ------- > > % ./gradlew publishToMavenLocal > Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8 > make: Nothing to be done for `all'. > :generatePomFileForMavenPublication > :bootstrapThrift UP-TO-DATE > :generateSources UP-TO-DATE > :compileGeneratedJava UP-TO-DATE > :processGeneratedResources UP-TO-DATE > :generatedClasses UP-TO-DATE > :compileJava UP-TO-DATE > :processResources UP-TO-DATE > :classes UP-TO-DATE > :jar UP-TO-DATE > :sourceJar UP-TO-DATE > :publishMavenPublicationToMavenLocal > Uploading: com/twitter/aurora/twitter-aurora/0.2.0-SNAPSHOT/twitter-aurora-0.2.0-20131213.012431-3.jar to repository remote at file:/Users/ksweeney/.m2/repository/ > Transferring 2577K from remote > Uploaded 2577K > Uploading: com/twitter/aurora/twitter-aurora/0.2.0-SNAPSHOT/twitter-aurora-0.2.0-20131213.012431-3-sources.jar to repository remote at file:/Users/ksweeney/.m2/repository/ > Transferring 301K from remote > Uploaded 301K > :publishToMavenLocal > > BUILD SUCCESSFUL > > Total time: 14.31 secs > > % ./pants setup_py src/main/python/twitter/aurora/config:config-packaged > Running "/opt/twitter/opt/python/bin/python2.7 setup.py sdist" in /Users/ksweeney/workspace/aurora/dist/twitter.aurora.config-0.2.0-snapshot > Wrote /Users/ksweeney/workspace/aurora/dist/twitter.aurora.config-0.2.0-snapshot.tar.gz > > > Thanks, > > Kevin Sweeney > > --===============4940211105215226898==--