Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3352339108919804722=="
MIME-Version: 1.0
Subject: Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
From: "Bill Farner" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>,
 "Maxim Khutornenko" <maxim@apache.org>,
 "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora" <dev@aurora.incubator.apache.org>,
 "Zameer Manji" <zmanji@gmail.com>
Date: Wed, 11 Dec 2013 01:08:50 -0000
Message-ID: <20131211010850.6673.88562@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20131211003936.6673.81051@reviews.apache.org>
In-Reply-To: <20131211003936.6673.81051@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>

--===============3352339108919804722==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Dec. 11, 2013, 12:39 a.m., Bill Farner wrote:
> > Ship It!
> 
> Zameer Manji wrote:
>     You forgot to commit it as well.

You were too fast for me, wasn't in a spot to push.  This is now on master.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/#review30154
-----------------------------------------------------------


On Dec. 11, 2013, 12:38 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 12:38 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24 
> 
> Diff: https://reviews.apache.org/r/16168/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


--===============3352339108919804722==--