Mailing-List: contact dev-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4992397659371237774=="
MIME-Version: 1.0
Subject: Re: Review Request 16130: First steps towards aurora client v2
From: "Mark Chu-Carroll" <mchucarroll@twitter.com>
To: "Brian Wickman" <wickman@gmail.com>, "Jonathan Boulle" <jon@twitter.com>
Cc: "Aurora" <dev@aurora.incubator.apache.org>,
 "Mark Chu-Carroll" <mchucarroll@twitter.com>
Date: Tue, 10 Dec 2013 22:13:25 -0000
Message-ID: <20131210221325.23250.7450@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mark Chu-Carroll" <noreply@reviews.apache.org>
References: <20131210012646.6673.99543@reviews.apache.org>
In-Reply-To: <20131210012646.6673.99543@reviews.apache.org>
Reply-To: "Mark Chu-Carroll" <mchucarroll@twitter.com>

--===============4992397659371237774==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16130/#review30136
-----------------------------------------------------------


src/main/python/twitter/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/16130/#comment57706>

    Ah, didn't realize that. I knew that it was really a python3 thing, but didn't realize it wasn't backported to 2.6.
    

src/main/python/twitter/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/16130/#comment57705>

    D'oh. Didn't notice that was still there. It was an easy-to-search for placeholder for something.


- Mark Chu-Carroll


On Dec. 9, 2013, 8:26 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16130/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 8:26 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First step towards aurora client v2! 
> 
> - Initial implementation of the noun/verb command and options processing framework.
> - Initial implementation of a command processing context for aurora commands.
> - Implementations of a "Job" noun and "create" and "kill" verbs.
> - Tests.
> 
> Note: not all of the v1 tests for the create and kill verbs have been migrated to the new
> framework; command processing contexts need a bit more work to make it easy to do the
> appropriate mocking/stubbing to support them. They'll be in the next change.
> 
> 
> Diffs
> -----
> 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/main/python/twitter/aurora/client/cli/__init__.py PRE-CREATION 
>   src/main/python/twitter/aurora/client/cli/context.py PRE-CREATION 
>   src/main/python/twitter/aurora/client/cli/jobs.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_create.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_kill.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/util.py PRE-CREATION 
>   src/test/python/twitter/aurora/client/commands/test_kill.py 3649969c77f992688a7ddbe592eda8d4edb94036 
> 
> Diff: https://reviews.apache.org/r/16130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


--===============4992397659371237774==--