aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 16484: AURORA-14: CI tests broken due to missing egg
Date Fri, 27 Dec 2013 19:14:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16484/#review30920
-----------------------------------------------------------


Definitely not an idea state to be in, but better than getting spammed by Jenkins for flaky
tests.


build-support/jenkins/build.sh
<https://reviews.apache.org/r/16484/#comment59151>

    For consistency with other scripts in the repo, mind changing this to #!/usr/bin/env bash?



build-support/jenkins/build.sh
<https://reviews.apache.org/r/16484/#comment59150>

    set -ex here? Otherwise a failed Java test run won't abort the script run.



build-support/jenkins/build.sh
<https://reviews.apache.org/r/16484/#comment59153>

    Glad to see this checked into source control, makes it much easier to enforce that the
person breaking the build should fix it.



src/test/python/twitter/aurora/executor/BUILD
<https://reviews.apache.org/r/16484/#comment59152>

    TODOs should have owners. Feel free to assign to yourself (TODO(Jake Farrell): ) or me
(TODO(Kevin Sweeney): ).


Thanks for the contribution!

- Kevin Sweeney


On Dec. 27, 2013, 10:50 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16484/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 10:50 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-14
>     https://issues.apache.org/jira/browse/AURORA-14
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-14: CI tests broken due to missing egg
> 
> Until Apache Mesos publishes the egg or we come up with a work around
> commenting out the tests which depend on the the mesos python client.
> 
> This patch also adds a script for the CI tests to capture this information
> and make it available for others to use.
> 
> I have linked MESOS-684 (deploying build artifacts) to AURORA-14 and have 
> started looking into a better approach to building this egg or making it 
> publicly available.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh PRE-CREATION 
>   src/test/python/twitter/aurora/executor/BUILD 9e574d5b86f0ba00dc8a10df8322863dcdf595e1

> 
> Diff: https://reviews.apache.org/r/16484/diff/
> 
> 
> Testing
> -------
> 
> Ran new jenkins build.sh script included with this patch and python tests passed with
> 
> src.test.python.twitter.aurora.admin.mesos_maintenance                          .....
  SUCCESS
> src.test.python.twitter.aurora.client.api.disambiguator                         .....
  SUCCESS
> src.test.python.twitter.aurora.client.api.instance_watcher                      .....
  SUCCESS
> src.test.python.twitter.aurora.client.api.job_monitor                           .....
  SUCCESS
> src.test.python.twitter.aurora.client.api.restarter                             .....
  SUCCESS
> src.test.python.twitter.aurora.client.api.scheduler_client                      .....
  SUCCESS
> src.test.python.twitter.aurora.client.api.updater                               .....
  SUCCESS
> src.test.python.twitter.aurora.client.binding_helper                            .....
  SUCCESS
> src.test.python.twitter.aurora.client.commands.core                             .....
  SUCCESS
> src.test.python.twitter.aurora.client.commands.run                              .....
  SUCCESS
> src.test.python.twitter.aurora.client.commands.ssh                              .....
  SUCCESS
> src.test.python.twitter.aurora.client.config                                    .....
  SUCCESS
> src.test.python.twitter.aurora.client.hooks.hooked_api                          .....
  SUCCESS
> src.test.python.twitter.aurora.client.hooks.non_hooked_api                      .....
  SUCCESS
> src.test.python.twitter.aurora.common.test_aurora_job_key                       .....
  SUCCESS
> src.test.python.twitter.aurora.common.test_cluster                              .....
  SUCCESS
> src.test.python.twitter.aurora.common.test_cluster_option                       .....
  SUCCESS
> src.test.python.twitter.aurora.common.test_clusters                             .....
  SUCCESS
> src.test.python.twitter.aurora.common.test_http_signaler                        .....
  SUCCESS
> src.test.python.twitter.aurora.config.test_base                                 .....
  SUCCESS
> src.test.python.twitter.aurora.config.test_constraint_parsing                   .....
  SUCCESS
> src.test.python.twitter.aurora.config.test_loader                               .....
  SUCCESS
> src.test.python.twitter.aurora.config.test_thrift                               .....
  SUCCESS
> src.test.python.twitter.aurora.executor.common.directory_sandbox                .....
  SUCCESS
> src.test.python.twitter.aurora.executor.common.health_checker                   .....
  SUCCESS
> src.test.python.twitter.aurora.executor.common.status_checker                   .....
  SUCCESS
> src.test.python.twitter.aurora.executor.common.task_info                        .....
  SUCCESS
> src.test.python.twitter.aurora.executor.executor_detector                       .....
  SUCCESS
> src.test.python.twitter.aurora.executor.executor_vars                           .....
  SUCCESS
> src.test.python.twitter.aurora.executor.thermos_task_runner                     .....
  SUCCESS
> src.test.python.twitter.thermos.common.test_pathspec                            .....
  SUCCESS
> src.test.python.twitter.thermos.common.test_planner                             .....
  SUCCESS
> src.test.python.twitter.thermos.common.test_task_planner                        .....
  SUCCESS
> src.test.python.twitter.thermos.config.test_schema                              .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_angry                                 .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_ephemerals                            .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_failing_runner                        .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_failure_limit                         .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_finalization                          .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_helper                                .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_process                               .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_runner_integration                    .....
  SUCCESS
> src.test.python.twitter.thermos.core.test_staged_kill                           .....
  SUCCESS
> src.test.python.twitter.thermos.monitoring.test_disk                            .....
  SUCCESS
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message