aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Boulle" <...@twitter.com>
Subject Re: Review Request 16311: Fixing updater diff.
Date Tue, 24 Dec 2013 01:13:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16311/#review30845
-----------------------------------------------------------



src/main/python/twitter/aurora/client/api/updater.py
<https://reviews.apache.org/r/16311/#comment59044>

    camelcase, ye heathen



src/main/python/twitter/aurora/client/api/updater.py
<https://reviews.apache.org/r/16311/#comment59048>

    what if this passes a list to self._convertDict?



src/main/python/twitter/aurora/client/api/updater.py
<https://reviews.apache.org/r/16311/#comment59045>

    camelcase


- Jonathan Boulle


On Dec. 23, 2013, 6:51 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16311/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2013, 6:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Hopefully fixing the thrift object diff once an for all. Instead of sorting __dict__
that proved to not cover all cases, converting thrift to sorted tuples via json serialization.
> 
> 
> Diffs
> -----
> 
>   src/main/python/twitter/aurora/client/api/updater.py 6e8e8a9fdfcf63a8fe0558d5ac36298601fd0552

>   src/test/python/twitter/aurora/client/api/test_updater.py ae4de2b57be16f8daf030210abda1ba05f9f30a0

> 
> Diff: https://reviews.apache.org/r/16311/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/twitter/aurora/client/api:updater
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message