aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@gmail.com>
Subject Re: Review Request 16311: Fixing updater diff.
Date Tue, 17 Dec 2013 19:27:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16311/#review30557
-----------------------------------------------------------



src/main/python/twitter/aurora/client/api/updater.py
<https://reviews.apache.org/r/16311/#comment58520>

    thirdparty imports go last



src/main/python/twitter/aurora/client/api/updater.py
<https://reviews.apache.org/r/16311/#comment58521>

    TSerialization takes a little bit of the ceremony out of this:
    
    from thrift.TSerialization import serialize
    from thrift.protocol import TJSONProtocol
    return serialize(config, protocol_factory=TJSONProtocol.TSimpleJSONProtocolFactory())
    


- Brian Wickman


On Dec. 17, 2013, 2:34 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16311/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 2:34 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Hopefully fixing the thrift object diff once an for all. Instead of sorting __dict__
that proved to not cover all cases, converting thrift to json and sorting json dict keys.
> 
> 
> Diffs
> -----
> 
>   src/main/python/twitter/aurora/client/api/updater.py 32bd6a1bf6bf401b0341b6e14e570d83c3e79dd5

>   src/test/python/twitter/aurora/client/api/test_updater.py 0b60d9e04428eb55168e3a9c3a394f19aed2f9d2

> 
> Diff: https://reviews.apache.org/r/16311/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/twitter/aurora/client/api:updater
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message