aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 16311: Fixing updater diff.
Date Tue, 17 Dec 2013 02:34:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16311/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Brian Wickman.


Repository: aurora


Description
-------

Hopefully fixing the thrift object diff once an for all. Instead of sorting __dict__ that
proved to not cover all cases, converting thrift to json and sorting json dict keys.


Diffs
-----

  src/main/python/twitter/aurora/client/api/updater.py 32bd6a1bf6bf401b0341b6e14e570d83c3e79dd5

  src/test/python/twitter/aurora/client/api/test_updater.py 0b60d9e04428eb55168e3a9c3a394f19aed2f9d2


Diff: https://reviews.apache.org/r/16311/diff/


Testing
-------

./pants src/test/python/twitter/aurora/client/api:updater


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message