aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16247: Adding random jitter for the initial GC task scheduling to better spread GC execution over time.
Date Tue, 17 Dec 2013 01:25:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16247/#review30511
-----------------------------------------------------------



src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java
<https://reviews.apache.org/r/16247/#comment58415>

    Without a remove(), this now stands out as a memory leak.  We either need to remove()
at some point or revert to Cache (preferably not relying on the map view of it).


- Bill Farner


On Dec. 16, 2013, 6:06 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16247/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:06 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Modified PulseMonitor to support random initial jitter delay.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java e31ce3d71c895f43ff73ad8e904124443ebdd72a

>   src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java bd7929d631cf45b4c2c7f39177bbafbd8f659071

>   src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java 5a8e13f0d719052286a7136707d7ed1aca87bab2

>   src/test/java/com/twitter/aurora/scheduler/PulseMonitorImplTest.java PRE-CREATION 
>   src/test/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncherTest.java ac5e3102925e2f26a12e18e95817403d18e25cb3

> 
> Diff: https://reviews.apache.org/r/16247/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message