aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <>
Subject Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.
Date Mon, 16 Dec 2013 22:31:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 16, 2013, 10:31 p.m.)

Review request for Aurora, Kevin Sweeney and Zameer Manji.

Repository: aurora


This change addresses two issues:
  - Ensure leadership is canceled whenever onDefeated is called
  - Scheduler should wait for registered to be called before attempting to invoke driver

Some additional structural changes were made:
  - is no longer used.  Instead, we invoke Driver.start() (non-blocking), and
the lifecycle uses Driver.join() to await exit.
    This allows us to avoid jumping through thread-safety hoops in unit tests.
  - A shim interface (DelayedActions) was added to SchedulerLifecycle to make testing easier
when capturing delayed closures.

Diffs (updated)

  src/main/java/com/twitter/aurora/scheduler/ e8fe170b2d9e1a752b152cedc0e006f10eaa5a11

  src/main/java/com/twitter/aurora/scheduler/ 346d52acc5fc9e4841e2dc8b424fc6d46d2cdc8c

  src/main/java/com/twitter/aurora/scheduler/ bd7929d631cf45b4c2c7f39177bbafbd8f659071

  src/main/java/com/twitter/aurora/scheduler/app/ ec99e01dd4f982ed5b794ff86b65e6f58d2a0e27

  src/main/java/com/twitter/aurora/scheduler/storage/testing/ ceef9d3bd4b43d2dcac0ab9129ae2b624ab654cf

  src/test/java/com/twitter/aurora/scheduler/ 5609b0b8b9a26a737558316e8e4fab0235704cb8

  src/test/java/com/twitter/aurora/scheduler/ PRE-CREATION 
  src/test/java/com/twitter/aurora/scheduler/app/ 4c381b946c8a3c7bbe1757d384d5d43dd74bb4d0



gradle clean build


Bill Farner

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message