aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <suman.karumuri...@gmail.com>
Subject Re: Review Request 16192: Installing JQuery and bootstrap from bower
Date Mon, 16 Dec 2013 22:27:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30459
-----------------------------------------------------------



build.gradle
<https://reviews.apache.org/r/16192/#comment58273>

    Fixed.



build.gradle
<https://reviews.apache.org/r/16192/#comment58274>

    Changed parens to match convention.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58296>

    Removed this section from here. Will move it to the rb with the local scheduler script.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58297>

    Marked it optional and updated description.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58331>

    Removed nvm as an install option.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58333>

    installing from brew will fix this.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58332>

    Added a few bower commands to get people started.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58319>

    done



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16192/#comment58334>

    removed.


- Suman Karumuri


On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 1:12 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Now installing JQuery and bootstrap from bower. 
> 
> Addded docs on managing bower dependencies and installing bower.
> 
> Added docs on running the isolated scheduler script.
> 
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be
used in java -jar option.
> 
> 
> Diffs
> -----
> 
>   build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 
>   docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7

>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16192/diff/
> 
> 
> Testing
> -------
> 
> Tested the UI using the isolated scheduler.
> 
> gradle clean build. 
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message