aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16268: Lock should be released if job does not exist
Date Mon, 16 Dec 2013 20:15:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16268/#review30476
-----------------------------------------------------------

Ship it!



src/main/python/twitter/aurora/client/api/updater.py
<https://reviews.apache.org/r/16268/#comment58302>

    Please include a comment on why this is deemed safe.  Since lock acquisition code is ~300
lines from here, it's not obvious why this is considered okay.


- Bill Farner


On Dec. 14, 2013, 1:21 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16268/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 1:21 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Releasing the lock if the update is unable to start for any reason.
> 
> 
> Diffs
> -----
> 
>   src/main/python/twitter/aurora/client/api/updater.py 32bd6a1bf6bf401b0341b6e14e570d83c3e79dd5

>   src/test/python/twitter/aurora/client/api/test_updater.py 0b60d9e04428eb55168e3a9c3a394f19aed2f9d2

> 
> Diff: https://reviews.apache.org/r/16268/diff/
> 
> 
> Testing
> -------
> 
> $ ./pants src/test/python/twitter/aurora/client/api:updater
> Build operating on targets: OrderedSet([PythonTests(src/test/python/twitter/aurora/client/api/BUILD:updater)])
> ============================================================================== test session
starts ===============================================================================
> platform darwin -- Python 2.7.3 -- pytest-2.5.0
> collected 24 items 
> 
> src/test/python/twitter/aurora/client/api/test_updater.py ........................
> 
> =========================================================================== 24 passed
in 0.26 seconds ============================================================================
> src.test.python.twitter.aurora.client.api.updater                               .....
  SUCCESS
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message