aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16267: Adding a script to run an isolated scheduler.
Date Mon, 16 Dec 2013 19:58:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30472
-----------------------------------------------------------



examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58294>

    license header is missing



examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58295>

    Usage string is not particularly helpful, consider dropping



examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58292>

    Can you remove the middle-man variable and just assign these all below?



examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58293>

    Please look into using ./gradlew run instead


- Bill Farner


On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 1:08 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding a script to run an isolated scheduler.
> 
> 
> Diffs
> -----
> 
>   examples/scheduler/scheduler-isolated.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16267/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message