aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16195: Added a header for the new UI
Date Sat, 14 Dec 2013 02:17:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30404
-----------------------------------------------------------



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58193>

    revert — this is more of intellij trying to be helpful.  however, it underscores the
importance of skimming your review diff before publishing (self-reviewing).



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58194>

    remove extra newline



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58195>

    Please avoid using "new" qualifier, it just leaves us with something we have to go back
and clean up later.



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58196>

    I'm confused — is this a landing page or a header?  Name suggests one thing, review
title suggests another.  If it's a landing page, how would you feel about discarding the '.html'?


- Bill Farner


On Dec. 13, 2013, 12:22 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 12:22 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a basic header for the new UI.
> 
> Updated ServletModule accordingly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7

>   src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16195/diff/
> 
> 
> Testing
> -------
> 
> Tested using local isolated scheduler. 
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message