aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16192: Installing JQuery and bootstrap from bower
Date Sat, 14 Dec 2013 01:52:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30396
-----------------------------------------------------------


It would be really nice to see the third-party sources placed in a directory that makes the
ownership blindingly obvious (and sheds our namespacing).  For example, third_party/javascript
would be awesome.  This will require some gradle spelunking, but i'm confident it's possible.


build.gradle
<https://reviews.apache.org/r/16192/#comment58176>

    indenting is inconsnstent



build.gradle
<https://reviews.apache.org/r/16192/#comment58177>

    single quotes are used elsewhere unless double quotes are needed for string interpolation
— please match that convention.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58179>

    1. please advise ./gradlew instead of gradle
    
    2. in theory, the 'run' task should let you do this in one command, args being specified
with ./gradlew run -PrunArgs='$CMD_LINE_ARGS'



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58178>

    Do i _need_ to install bower?  Please explain why one needs to do this, since most people
will not need to.



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58180>

    This makes me extremely uncomfortable.  I recognize that to some degree we are blindly
executing others' code frequently, but something about encouraging execution of unverified
and arbitrarily-changing shell code to be particularly nasty.  Can you at least fix this at
a sha and include a checksum that someone can verify?



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58184>

    Is it possible to install into a directory within the repository, so as to avoid conflict
with what's installed on people's machines?



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58183>

    Okay, i've got bower installed...what should i do with it now?



docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58181>

    revert



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16192/#comment58185>

    remove or assign


- Bill Farner


On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 1:12 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Now installing JQuery and bootstrap from bower. 
> 
> Addded docs on managing bower dependencies and installing bower.
> 
> Added docs on running the isolated scheduler script.
> 
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be
used in java -jar option.
> 
> 
> Diffs
> -----
> 
>   build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 
>   docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7

>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json
PRE-CREATION 
>   src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16192/diff/
> 
> 
> Testing
> -------
> 
> Tested the UI using the isolated scheduler.
> 
> gradle clean build. 
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message